From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>,
Minwoo Im <minwoo.im.dev@gmail.com>
Subject: Re: [PATCH 1/9] block: move the BIO_NO_PAGE_REF check into bio_release_pages
Date: Thu, 27 Jun 2019 05:34:12 +0900 [thread overview]
Message-ID: <20190626203412.GD4934@minwooim-desktop> (raw)
In-Reply-To: <20190626134928.7988-2-hch@lst.de>
On 19-06-26 15:49:20, Christoph Hellwig wrote:
> Move the BIO_NO_PAGE_REF check into bio_release_pages instead of
> duplicating it in both callers.
This part looks good to me.
> Also make the function available outside of bio.c so that we can
> reuse it in other direct I/O implementations.
This is also for the next patches.
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
next prev parent reply other threads:[~2019-06-26 20:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 13:49 cleanup bio page releasing Christoph Hellwig
2019-06-26 13:49 ` [PATCH 1/9] block: move the BIO_NO_PAGE_REF check into bio_release_pages Christoph Hellwig
2019-06-26 20:34 ` Minwoo Im [this message]
2019-06-26 13:49 ` [PATCH 2/9] block: optionally mark pages dirty in bio_release_pages Christoph Hellwig
2019-06-26 20:52 ` Minwoo Im
2019-06-27 0:21 ` Chaitanya Kulkarni
2019-06-27 10:24 ` Minwoo Im
2019-06-27 8:27 ` Christoph Hellwig
2019-06-27 10:22 ` Minwoo Im
2019-06-26 13:49 ` [PATCH 3/9] block: use bio_release_pages in bio_unmap_user Christoph Hellwig
2019-06-26 20:47 ` Chaitanya Kulkarni
2019-06-26 13:49 ` [PATCH 4/9] block: use bio_release_pages in bio_map_user_iov Christoph Hellwig
2019-06-26 20:41 ` Minwoo Im
2019-06-26 20:47 ` Chaitanya Kulkarni
2019-06-26 13:49 ` [PATCH 5/9] iomap: use bio_release_pages in iomap_dio_bio_end_io Christoph Hellwig
2019-06-26 20:42 ` Minwoo Im
2019-06-26 20:47 ` Chaitanya Kulkarni
2019-06-26 13:49 ` [PATCH 6/9] block_dev: use bio_release_pages in blkdev_bio_end_io Christoph Hellwig
2019-06-26 20:44 ` Minwoo Im
2019-06-26 20:47 ` Chaitanya Kulkarni
2019-06-26 13:49 ` [PATCH 7/9] block_dev: use bio_release_pages in bio_unmap_user Christoph Hellwig
2019-06-26 20:48 ` Chaitanya Kulkarni
2019-06-26 13:49 ` [PATCH 8/9] direct-io: use bio_release_pages in dio_bio_complete Christoph Hellwig
2019-06-26 20:49 ` Chaitanya Kulkarni
2019-06-26 13:49 ` [PATCH 9/9] block: never take page references for ITER_BVEC Christoph Hellwig
2019-06-26 20:57 ` Minwoo Im
2019-06-29 15:48 ` cleanup bio page releasing Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626203412.GD4934@minwooim-desktop \
--to=minwoo.im.dev@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox