Re: [PATCH 2/5] block: update error message in submit_bio()

Minwoo Im
2019-07-03T00:43:44Z

On 19-07-01 14:57:23, Chaitanya Kulkarni wrote:
> The existing code in the submit_bio() relies on the op_is_write().
> op_is_write() checks for the last bit in the bio_op() and we only
> print WRITE or READ as a bio_op().
>
> It is hard to understand which bio op based on READ/WRITE in
> submit_bio() with addition of newly discussed REQ_OP_XXX. [1]
>
> Modify the error message in submit_bio() to print correct REQ_OP_XXX
> with the help of blk_op_str().
>
> [1] https://www.spinics.net/lists/linux-block/msg41884.html.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

It looks good to me.

Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>