From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] null_blk: use SECTOR_SHIFT consistently
Date: Wed, 3 Jul 2019 00:09:55 -0300 [thread overview]
Message-ID: <20190703030955.GA11462@continental> (raw)
In-Reply-To: <20190702202857.4433-1-chaitanya.kulkarni@wdc.com>
On Tue, Jul 02, 2019 at 01:28:57PM -0700, Chaitanya Kulkarni wrote:
> This is a pure cleanup patch and doesn't change any functionality.
> In null_blk_main.c we use mixed style of the code SECTOR_SHIFT and
> >> 9. Get rid of the >> 9 and use SECTOR_SHIFT everywhere.
>
Agreed, much better than a magic number.
Acked-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
next prev parent reply other threads:[~2019-07-03 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 20:28 [PATCH] null_blk: use SECTOR_SHIFT consistently Chaitanya Kulkarni
2019-07-03 3:09 ` Marcos Paulo de Souza [this message]
2019-07-03 5:23 ` Minwoo Im
2019-07-08 18:51 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703030955.GA11462@continental \
--to=marcos.souza.org@gmail.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox