From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 2/3] block: create bio_try_merge_pc_page helper __bio_add_pc_page
Date: Wed, 3 Jul 2019 16:34:59 +0200 [thread overview]
Message-ID: <20190703143459.GA10149@lst.de> (raw)
In-Reply-To: <20190703133446.GE4026@x250.microfocus.com>
On Wed, Jul 03, 2019 at 03:34:55PM +0200, Johannes Thumshirn wrote:
> On Wed, Jul 03, 2019 at 06:00:35AM -0700, Christoph Hellwig wrote:
> [snip]
> > phys_addr_t addr2 = page_to_phys(page) + offset + len - 1;
> >
> > if ((addr1 | mask) != (addr2 | mask))
> > return false;
> > -
> > if (bv->bv_len + len > queue_max_segment_size(q))
> > return false;
> > -
> > - return true;
> > + return __bio_try_merge_page(bio, page, len, offset, same_page);
> > }
>
> That's a lot of spurious whitespace changes here.
Really just an empty line going away outside the directly touched code.
I think it is more effective to boundle that here rather than having
an extra patch for that..
next prev parent reply other threads:[~2019-07-03 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 13:00 bio_add_pc_page cleanups Christoph Hellwig
2019-07-03 13:00 ` [PATCH 1/3] block: improve the gap check in __bio_add_pc_page Christoph Hellwig
2019-07-03 14:40 ` Johannes Thumshirn
2019-07-03 13:00 ` [PATCH 2/3] block: create bio_try_merge_pc_page helper __bio_add_pc_page Christoph Hellwig
2019-07-03 13:34 ` Johannes Thumshirn
2019-07-03 14:34 ` Christoph Hellwig [this message]
2019-07-03 14:40 ` Johannes Thumshirn
2019-07-03 13:00 ` [PATCH 3/3] block: move same page handling from __bio_add_pc_page to the callers Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703143459.GA10149@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox