From: Josef Bacik <josef@toxicpanda.com>
To: axboe@kernel.dk, linux-block@vger.kernel.org, kernel-team@fb.com,
peterz@infradead.org, oleg@redhat.com
Subject: [PATCH 4/4] rq-qos: don't reset has_sleepers on spurious wakeups
Date: Mon, 15 Jul 2019 16:11:19 -0400 [thread overview]
Message-ID: <20190715201120.72749-5-josef@toxicpanda.com> (raw)
In-Reply-To: <20190715201120.72749-1-josef@toxicpanda.com>
If we had multiple sleepers before we don't need to worry about never
being woken up. If we're woken up randomly without having gotten our
inflight token then we need to go back to sleep, we won't be properly
woken up without being given our inflight token anyway so this resetting
isn't needed.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
block/blk-rq-qos.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-rq-qos.c b/block/blk-rq-qos.c
index f4aa7b818cf5..35bc6f54d088 100644
--- a/block/blk-rq-qos.c
+++ b/block/blk-rq-qos.c
@@ -261,7 +261,6 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data,
break;
}
io_schedule();
- has_sleeper = false;
} while (1);
finish_wait(&rqw->wait, &data.wq);
}
--
2.17.1
next prev parent reply other threads:[~2019-07-15 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 20:11 [PATCH 0/4][v2] rq-qos memory barrier shenanigans Josef Bacik
2019-07-15 20:11 ` [PATCH 1/4] wait: add wq_has_single_sleeper helper Josef Bacik
2019-07-15 20:11 ` [PATCH 2/4] rq-qos: fix missed wake-ups in rq_qos_throttle Josef Bacik
2019-07-15 20:11 ` [PATCH 3/4] rq-qos: use READ_ONCE/WRITE_ONCE for got_token Josef Bacik
2019-07-16 8:29 ` Oleg Nesterov
2019-07-15 20:11 ` Josef Bacik [this message]
2019-07-16 8:35 ` [PATCH 4/4] rq-qos: don't reset has_sleepers on spurious wakeups Oleg Nesterov
2019-07-16 8:39 ` [PATCH 0/4][v2] rq-qos memory barrier shenanigans Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715201120.72749-5-josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).