From: Oleg Nesterov <oleg@redhat.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, kernel-team@fb.com,
peterz@infradead.org
Subject: Re: [PATCH 0/4][v2] rq-qos memory barrier shenanigans
Date: Tue, 16 Jul 2019 10:39:08 +0200 [thread overview]
Message-ID: <20190716083907.GC15528@redhat.com> (raw)
In-Reply-To: <20190715201120.72749-1-josef@toxicpanda.com>
On 07/15, Josef Bacik wrote:
>
> This is the patch series to address the hang we saw in production because of
> missed wakeups, and the other issues that Oleg noticed while reviewing the code.
You missed another problem. See
https://lore.kernel.org/linux-block/20190711114543.GA14901@redhat.com/
IOW, rq_qos_wait() needs set_current_state(TASK_UNINTERRUPTIBLE) after
io_schedule().
Oleg.
prev parent reply other threads:[~2019-07-16 8:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 20:11 [PATCH 0/4][v2] rq-qos memory barrier shenanigans Josef Bacik
2019-07-15 20:11 ` [PATCH 1/4] wait: add wq_has_single_sleeper helper Josef Bacik
2019-07-15 20:11 ` [PATCH 2/4] rq-qos: fix missed wake-ups in rq_qos_throttle Josef Bacik
2019-07-15 20:11 ` [PATCH 3/4] rq-qos: use READ_ONCE/WRITE_ONCE for got_token Josef Bacik
2019-07-16 8:29 ` Oleg Nesterov
2019-07-15 20:11 ` [PATCH 4/4] rq-qos: don't reset has_sleepers on spurious wakeups Josef Bacik
2019-07-16 8:35 ` Oleg Nesterov
2019-07-16 8:39 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716083907.GC15528@redhat.com \
--to=oleg@redhat.com \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).