From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC9FDC76186 for ; Wed, 24 Jul 2019 01:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8870E2238C for ; Wed, 24 Jul 2019 01:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728522AbfGXBnY (ORCPT ); Tue, 23 Jul 2019 21:43:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43314 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728487AbfGXBnY (ORCPT ); Tue, 23 Jul 2019 21:43:24 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A20993DDBE; Wed, 24 Jul 2019 01:43:24 +0000 (UTC) Received: from ming.t460p (ovpn-8-24.pek2.redhat.com [10.72.8.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B739D60A9F; Wed, 24 Jul 2019 01:43:16 +0000 (UTC) Date: Wed, 24 Jul 2019 09:43:11 +0800 From: Ming Lei To: Sagi Grimberg Cc: Jens Axboe , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Max Gurtovoy , Keith Busch , Christoph Hellwig Subject: Re: [PATCH 4/5] nvme: wait until all completed request's complete fn is called Message-ID: <20190724014310.GC22421@ming.t460p> References: <20190722053954.25423-1-ming.lei@redhat.com> <20190722053954.25423-5-ming.lei@redhat.com> <95f000ba-d3c8-f215-5e32-4b6e44954fb1@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95f000ba-d3c8-f215-5e32-4b6e44954fb1@grimberg.me> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 24 Jul 2019 01:43:24 +0000 (UTC) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jul 23, 2019 at 01:29:54PM -0700, Sagi Grimberg wrote: > Reviewed-by: Sagi Grimberg > > What about fc? I know that they are not canceling a request, but > they still complete it, shouldn't it also wait before removing? fc doesn't use blk-mq request abort mechanism, so its own approach may sync with abort well. However, for normal completion, I think the wait is still needed, will do it in V2. Thanks, Ming