From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14555C76186 for ; Wed, 24 Jul 2019 21:33:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D86112147A for ; Wed, 24 Jul 2019 21:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564004030; bh=K5+1kIkmgRZ7/UJaVl3quwET9K+LYBIjdiMgQ/9ni4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GPKfXgZY/4iPsgSqA1Yg7jwUaI2OcS3xm3pJ1xGp/2kDQuLfzaZOYOMWiXEEXRwyY gxMLcQHrpOKwpcJzNwQRoCkXJXjQfUzIJna11v/HQsyvJ2Cwp4n/3dOGNf8O4bv7U+ RRIoS/IWUwa2xlx+aodyBiQ9krYGRmq7fdc9vgg8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726701AbfGXVdu (ORCPT ); Wed, 24 Jul 2019 17:33:50 -0400 Received: from mga09.intel.com ([134.134.136.24]:41434 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfGXVdu (ORCPT ); Wed, 24 Jul 2019 17:33:50 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 14:33:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,304,1559545200"; d="scan'208";a="181251022" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga002.jf.intel.com with ESMTP; 24 Jul 2019 14:33:49 -0700 Date: Wed, 24 Jul 2019 15:30:54 -0600 From: Keith Busch To: Ming Lei Cc: davidc502 , linux-block@vger.kernel.org, ilnux-nvme@lists.infradead.org Subject: Re: fstrim error - AORUS NVMe Gen4 SSD Message-ID: <20190724213054.GA5921@localhost.localdomain> References: <20190723021928.GF30776@ming.t460p> <4a7ec7aa-f6ee-f9dc-4a17-38f2b169c721@tds.net> <20190723043803.GB13829@ming.t460p> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723043803.GB13829@ming.t460p> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jul 23, 2019 at 12:38:04PM +0800, Ming Lei wrote: > From the IO trace, discard command(nvme_cmd_dsm) is failed: > > kworker/15:1H-462 [015] .... 91814.342452: nvme_setup_cmd: nvme0: disk=nvme0n1, qid=7, cmdid=552, nsid=1, flags=0x0, meta=0x0, cmd=(nvme_cmd_dsm nr=0, attributes=4) > -0 [013] d.h. 91814.342708: nvme_complete_rq: nvme0: disk=nvme0n1, qid=7, cmdid=552, res=0, retries=0, flags=0x0, status=8198 > > And the returned error code is 0x8198, I am not sure how to parse the > 'Command Specific Status Values' of 0x98, maybe Christoph, Keith or our other > NVMe guys can help to understand the failure. The 198h status code is still marked reserved in the latest spec for an NVM command set, so not sure what to make of it. I think we would have to refer back to the vendor.