From: Bart Van Assche <bvanassche@acm.org>
To: Omar Sandoval <osandov@fb.com>
Cc: linux-block@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH blktests] tests/srp/014: Add a test that triggers a SCSI reset while I/O is ongoing
Date: Thu, 1 Aug 2019 15:09:37 -0700 [thread overview]
Message-ID: <20190801220937.133392-1-bvanassche@acm.org> (raw)
This test triggers the task management function handling code in the SRP
initiator and target drivers. This test verifies the following kernel
patch: fd5614124406 ("scsi: RDMA/srp: Fix a sleep-in-invalid-context
bug") # v5.3.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
A note regarding the copyright notice: I wrote this patch more than a year
ago. Hence the copyright attribution to Western Digital.
tests/srp/014 | 104 ++++++++++++++++++++++++++++++++++++++++++++++
tests/srp/014.out | 2 +
2 files changed, 106 insertions(+)
create mode 100755 tests/srp/014
create mode 100644 tests/srp/014.out
diff --git a/tests/srp/014 b/tests/srp/014
new file mode 100755
index 000000000000..bc2e844abdd2
--- /dev/null
+++ b/tests/srp/014
@@ -0,0 +1,104 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
+# Copyright (c) 2016-2018 Western Digital Corporation or its affiliates
+
+. tests/srp/rc
+
+DESCRIPTION="Run sg_reset while I/O is ongoing"
+TIMED=1
+
+# $1: SCSI device of which to change the state to running, e.g. sdc.
+make_running() {
+ local dev=$1 sp state
+
+ for sp in /sys/class/scsi_device/*/device/block/"$dev"; do
+ if [ -e "$sp" ]; then
+ break
+ else
+ return 1
+ fi
+ done
+ sp=$(dirname "$(dirname "$sp")")/state
+ # If the SCSI error handler changed the device state to offline,
+ # change the state back to running.
+ state=$(<"$sp")
+ if [ "$state" = offline ]; then
+ echo running > "$sp"
+ echo "$dev: state $state -> running" >>"$FULL"
+ else
+ echo "$dev: state $state" >>"$FULL"
+ fi
+}
+
+# $1: dm device to examine, e.g.
+# /dev/disk/by-id/dm-uuid-mpath-360014056e756c6c62300000000000000
+make_all_running() {
+ local d h dev=$1
+
+ while [ -L "$dev" ]; do
+ dev=$(realpath "$dev")
+ done
+ dev=${dev#/dev/}
+ for h in /sys/class/block/*/holders/"$dev"; do
+ [ -e "$h" ] || continue
+ d=$(basename "$(dirname "$(dirname "$h")")")
+ make_running "$d"
+ done
+}
+
+# $1: dm device to act on.
+set_running_loop() {
+ local dev="$1"
+
+ [ -e "$dev" ] || return $?
+ while true; do
+ sleep 1
+ make_all_running "$dev"
+ done
+ echo "set_running_loop $dev finished" >>"$FULL"
+}
+
+# $1: dm device to reset periodically; $2: how long the reset loop should run.
+sg_reset_loop() {
+ local cmd dev="$1" duration="$2" deadline i=0 reset_type
+
+ [ -e "$dev" ] || return $?
+ [ -n "$duration" ] || return $?
+ reset_type=(-d -b)
+ deadline=$(($(uptime_s) + duration))
+ while true; do
+ sleep_until 1 ${deadline} || break
+ cmd="sg_reset --no-esc ${reset_type[i++ % 2]} $dev"
+ { echo "+ $cmd"; eval "$cmd"; } >>"$FULL" 2>&1
+ done
+ echo "sg_reset_loop $dev finished" >>"$FULL"
+}
+
+test_sg_reset() {
+ local dev fio_status m job jobfile
+
+ use_blk_mq y y || return $?
+ dev=$(get_bdev 0) || return $?
+ sg_reset_loop "$dev" "$TIMEOUT" &
+ jobfile=$(mktemp)
+ # Redirect stderr to suppress the bash "Terminated" message.
+ (set_running_loop "$dev" 2>/dev/null & echo $! > "$jobfile")
+ job=$(<"$jobfile")
+ rm -f "$jobfile"
+ run_fio --verify=md5 --rw=randwrite --bs=64K --loops=$((10**6)) \
+ --iodepth=16 --group_reporting --sync=1 --direct=1 \
+ --ioengine=libaio --runtime="${TIMEOUT}" \
+ --filename="$dev" --name=sg-reset-test --thread --numjobs=1 \
+ --output="${RESULTS_DIR}/srp/fio-output-014.txt" \
+ >>"$FULL"
+ fio_status=$?
+ kill "$job"
+ make_all_running "$dev"
+ wait
+ return $fio_status
+}
+
+test() {
+ trap 'trap "" EXIT; teardown' EXIT
+ setup && test_sg_reset && echo Passed
+}
diff --git a/tests/srp/014.out b/tests/srp/014.out
new file mode 100644
index 000000000000..5e25d8e8672d
--- /dev/null
+++ b/tests/srp/014.out
@@ -0,0 +1,2 @@
+Configured SRP target driver
+Passed
--
2.22.0.770.g0f2c4a37fd-goog
next reply other threads:[~2019-08-01 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 22:09 Bart Van Assche [this message]
2019-08-07 0:11 ` [PATCH blktests] tests/srp/014: Add a test that triggers a SCSI reset while I/O is ongoing Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801220937.133392-1-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).