From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA203C433FF for ; Tue, 6 Aug 2019 10:24:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0B8420B1F for ; Tue, 6 Aug 2019 10:24:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W6yaIi5E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732290AbfHFKXy (ORCPT ); Tue, 6 Aug 2019 06:23:54 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:44087 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726713AbfHFKXy (ORCPT ); Tue, 6 Aug 2019 06:23:54 -0400 Received: by mail-ed1-f66.google.com with SMTP id k8so81764920edr.11; Tue, 06 Aug 2019 03:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nHAZm0GZeVyi0k2jXAqZJ6+K/F+OXmkni52x4h/2WKU=; b=W6yaIi5Eo9POup4WUZfRIHlyJ8IGxq+DvAHVwLOkie5rWs0Fk9vvDlFBrcwFpoK+VL Tj0JydlTDm1RimAaQo0IBtt0NGVl1bzVHDI3DDYlzgCDaqlQoQAc43r3qj7Ivm8RcyhC eJKN/HvOYiTmeFsPcLvX9daiIIXSgCUlLR/bJOUTieraPl+UPBZrrJQFtXaclzq/bra+ AF+Zksj+MchmgA6LNPHlmULwQwjjdyA4PjX01pHQg3/ZCrqEzkOKxlLBpKVN6jmSv01r C80UUtClWdQqFzFISc93OQENgf7/tFHSDLNumfYDptwVttiXjO3XgQEc1Tc+85IfBkBA 9y8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nHAZm0GZeVyi0k2jXAqZJ6+K/F+OXmkni52x4h/2WKU=; b=tdMKdsBAdbrtBhxYHaokf5Ibn8HPuH0qfkGNbT9ewlu3G53+zDCY7us5ksycetQ2h7 FwJDyc/3bYG7IxkiJz1H2jq4VaD5ifz+PK4x3PcJmgURTUAamDCVMppm5BTWasdnuFNI FdaX/uicv9gbV3FqAk5Vontu7PjgXXrPEQKGz77dBRPW+YMANLuv6ffSxkAAyq98CQ1v +hGjiNrdkkyUBD3vk6qqimDRME+4CyQAuj6gHpLIQcJgikQunC9ja1Wz07efWj+DIr/x W5v/IYufaoqS+IP5nNJFJqLkwUwTBAIDDCKJrem5zWYBThyvXe8hLj3kcqnqGAv6Esjf mGeg== X-Gm-Message-State: APjAAAXnHzPpDYVmlDzTcxBmn72mkgc1nizfYx7ehTUl3n9XDfEeYsA7 KfWiSDPa9ZRdjbGSZ7rTp3k= X-Google-Smtp-Source: APXvYqxNSOOeEKipsPzXzNB35eNLgJeH0dlFgOZerwtyAg1/J6mRzv95o7+dpOqMTQU7nPiqxQkS0w== X-Received: by 2002:a17:906:8386:: with SMTP id p6mr2356514ejx.139.1565087031956; Tue, 06 Aug 2019 03:23:51 -0700 (PDT) Received: from continental ([187.112.244.117]) by smtp.gmail.com with ESMTPSA id jt17sm14779247ejb.90.2019.08.06.03.23.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 03:23:51 -0700 (PDT) Date: Tue, 6 Aug 2019 07:24:56 -0300 From: Marcos Paulo de Souza To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, Jens Axboe , Keith Busch , Sagi Grimberg , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Kai =?iso-8859-1?Q?M=E4kisara?= , Hannes Reinecke , Omar Sandoval , Ming Lei , Chaitanya Kulkarni , Damien Le Moal , Bart Van Assche , "open list:BLOCK LAYER" , "open list:NVM EXPRESS DRIVER" , "open list:SCSI SUBSYSTEM" , "open list:SCSI TARGET SUBSYSTEM" Subject: Re: [PATCH] block: Remove request_queue argument from blk_execute_rq_nowait Message-ID: <20190806102456.GA29914@continental> References: <20190806011754.7722-1-marcos.souza.org@gmail.com> <20190806051911.GA13409@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190806051911.GA13409@lst.de> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Aug 06, 2019 at 07:19:11AM +0200, Christoph Hellwig wrote: > On Mon, Aug 05, 2019 at 10:17:51PM -0300, Marcos Paulo de Souza wrote: > > +void blk_execute_rq_nowait(struct gendisk *bd_disk, struct request *rq, > > + int at_head, rq_end_io_fn *done) > > We store a ->rq_disk in struct request, so we should also not need > that. And at_head should either become a bool, or be replaced with > a flags argument, ints used boolean are usually not a good idea. Makes sense. > > > @@ -81,7 +80,7 @@ void blk_execute_rq(struct request_queue *q, struct gendisk *bd_disk, > > And all the same argument changes that apply to blk_execute_rq_nowait > apply to blk_execute_rq as well. Thanks for the suggestions, I will send a v2 soon.