Re: [PATCH] block: remove queue_head

[Ming Lei <ming.lei@redhat.com>]

On Fri, Aug 16, 2019 at 02:12:33PM -0700, Junxiao Bi wrote:
> The dispatch list was not used any more as lagency block gone.
> 
> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
> ---
>  block/blk-core.c       | 1 -
>  include/linux/blkdev.h | 4 ----
>  2 files changed, 5 deletions(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index d0cc6e14d2f0..82c9c1ef1de6 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -479,7 +479,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id)
>  	if (!q)
>  		return NULL;
>  
> -	INIT_LIST_HEAD(&q->queue_head);
>  	q->last_merge = NULL;
>  
>  	q->id = ida_simple_get(&blk_queue_ida, 0, 0, gfp_mask);
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 1ef375dafb1c..680c4d08f1a2 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -391,10 +391,6 @@ static inline int blkdev_reset_zones_ioctl(struct block_device *bdev,
>  #endif /* CONFIG_BLK_DEV_ZONED */
>  
>  struct request_queue {
> -	/*
> -	 * Together with queue_head for cacheline sharing
> -	 */
> -	struct list_head	queue_head;
>  	struct request		*last_merge;
>  	struct elevator_queue	*elevator;
>  
> -- 
> 2.17.1
> 

Reviewed-by: Ming Lei <ming.lei@redhat.com>

thanks,
Ming