* [PATCH] block: remove queue_head
@ 2019-08-16 21:12 Junxiao Bi
2019-08-16 22:11 ` Bart Van Assche
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Junxiao Bi @ 2019-08-16 21:12 UTC (permalink / raw)
To: linux-block; +Cc: axboe, junxiao.bi
The dispatch list was not used any more as lagency block gone.
Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
---
block/blk-core.c | 1 -
include/linux/blkdev.h | 4 ----
2 files changed, 5 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index d0cc6e14d2f0..82c9c1ef1de6 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -479,7 +479,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id)
if (!q)
return NULL;
- INIT_LIST_HEAD(&q->queue_head);
q->last_merge = NULL;
q->id = ida_simple_get(&blk_queue_ida, 0, 0, gfp_mask);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 1ef375dafb1c..680c4d08f1a2 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -391,10 +391,6 @@ static inline int blkdev_reset_zones_ioctl(struct block_device *bdev,
#endif /* CONFIG_BLK_DEV_ZONED */
struct request_queue {
- /*
- * Together with queue_head for cacheline sharing
- */
- struct list_head queue_head;
struct request *last_merge;
struct elevator_queue *elevator;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] block: remove queue_head
2019-08-16 21:12 [PATCH] block: remove queue_head Junxiao Bi
@ 2019-08-16 22:11 ` Bart Van Assche
2019-08-19 3:58 ` Ming Lei
2019-08-19 14:56 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2019-08-16 22:11 UTC (permalink / raw)
To: Junxiao Bi, linux-block; +Cc: axboe
On 8/16/19 2:12 PM, Junxiao Bi wrote:
> The dispatch list was not used any more as lagency block gone.
^^^^^^^
legacy?
Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] block: remove queue_head
2019-08-16 21:12 [PATCH] block: remove queue_head Junxiao Bi
2019-08-16 22:11 ` Bart Van Assche
@ 2019-08-19 3:58 ` Ming Lei
2019-08-19 14:56 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Ming Lei @ 2019-08-19 3:58 UTC (permalink / raw)
To: Junxiao Bi; +Cc: linux-block, axboe
On Fri, Aug 16, 2019 at 02:12:33PM -0700, Junxiao Bi wrote:
> The dispatch list was not used any more as lagency block gone.
>
> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
> ---
> block/blk-core.c | 1 -
> include/linux/blkdev.h | 4 ----
> 2 files changed, 5 deletions(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index d0cc6e14d2f0..82c9c1ef1de6 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -479,7 +479,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id)
> if (!q)
> return NULL;
>
> - INIT_LIST_HEAD(&q->queue_head);
> q->last_merge = NULL;
>
> q->id = ida_simple_get(&blk_queue_ida, 0, 0, gfp_mask);
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 1ef375dafb1c..680c4d08f1a2 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -391,10 +391,6 @@ static inline int blkdev_reset_zones_ioctl(struct block_device *bdev,
> #endif /* CONFIG_BLK_DEV_ZONED */
>
> struct request_queue {
> - /*
> - * Together with queue_head for cacheline sharing
> - */
> - struct list_head queue_head;
> struct request *last_merge;
> struct elevator_queue *elevator;
>
> --
> 2.17.1
>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
thanks,
Ming
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] block: remove queue_head
2019-08-16 21:12 [PATCH] block: remove queue_head Junxiao Bi
2019-08-16 22:11 ` Bart Van Assche
2019-08-19 3:58 ` Ming Lei
@ 2019-08-19 14:56 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2019-08-19 14:56 UTC (permalink / raw)
To: Junxiao Bi, linux-block
On 8/16/19 3:12 PM, Junxiao Bi wrote:
> The dispatch list was not used any more as lagency block gone.
Thanks, applied with the subject/body rewritten somewhat.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-19 14:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-16 21:12 [PATCH] block: remove queue_head Junxiao Bi
2019-08-16 22:11 ` Bart Van Assche
2019-08-19 3:58 ` Ming Lei
2019-08-19 14:56 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).