From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org, hch@lst.de, axboe@kernel.dk
Subject: Re: [PATCH V3 5/6] null_blk: create a helper for zoned devices
Date: Thu, 22 Aug 2019 02:58:34 +0200 [thread overview]
Message-ID: <20190822005834.GF10938@lst.de> (raw)
In-Reply-To: <20190821061314.3262-6-chaitanya.kulkarni@wdc.com>
> +static inline blk_status_t null_handle_zoned(struct nullb_cmd *cmd,
> + enum req_opf op, sector_t sector,
> + sector_t nr_sectors)
> +{
Shouldn't this go into null_blk_zoned.c? Also the indentation for the
here seems odd.
> + blk_status_t sts = BLK_STS_OK;
> +
> + switch (op) {
> + case REQ_OP_WRITE:
> + sts = null_zone_write(cmd, sector, nr_sectors);
> + break;
> + case REQ_OP_ZONE_RESET:
> + sts = null_zone_reset(cmd, sector);
> + break;
> + default:
> + break;
> + }
> +
> + return sts;
Why not:
switch (op) {
case REQ_OP_WRITE:
return null_zone_write(cmd, sector, nr_sectors);
case REQ_OP_ZONE_RESET:
return null_zone_reset(cmd, sector);
default:
return BLK_STS_OK;
}
next prev parent reply other threads:[~2019-08-22 0:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 6:13 [PATCH V3 0/6] null_blk: simplify null_handle_cmd() Chaitanya Kulkarni
2019-08-21 6:13 ` [PATCH V3 1/6] null_blk: move duplicate code to callers Chaitanya Kulkarni
2019-08-22 0:55 ` Christoph Hellwig
2019-08-21 6:13 ` [PATCH V3 2/6] null_blk: create a helper for throttling Chaitanya Kulkarni
2019-08-22 0:55 ` Christoph Hellwig
2019-08-21 6:13 ` [PATCH V3 3/6] null_blk: create a helper for badblocks Chaitanya Kulkarni
2019-08-22 0:55 ` Christoph Hellwig
2019-08-21 6:13 ` [PATCH V3 4/6] null_blk: create a helper for mem-backed ops Chaitanya Kulkarni
2019-08-22 0:56 ` Christoph Hellwig
2019-08-21 6:13 ` [PATCH V3 5/6] null_blk: create a helper for zoned devices Chaitanya Kulkarni
2019-08-22 0:58 ` Christoph Hellwig [this message]
2019-08-22 2:23 ` Chaitanya Kulkarni
2019-08-21 6:13 ` [PATCH V3 6/6] null_blk: create a helper for req completion Chaitanya Kulkarni
2019-08-22 0:59 ` Christoph Hellwig
2019-08-22 2:17 ` Chaitanya Kulkarni
2019-08-22 2:23 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822005834.GF10938@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).