From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E88DCC3A59E for ; Wed, 4 Sep 2019 05:51:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2DB023400 for ; Wed, 4 Sep 2019 05:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbfIDFv3 (ORCPT ); Wed, 4 Sep 2019 01:51:29 -0400 Received: from verein.lst.de ([213.95.11.211]:36140 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbfIDFv3 (ORCPT ); Wed, 4 Sep 2019 01:51:29 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B0AEE227A8A; Wed, 4 Sep 2019 07:51:26 +0200 (CEST) Date: Wed, 4 Sep 2019 07:51:26 +0200 From: Christoph Hellwig To: Max Gurtovoy Cc: linux-block@vger.kernel.org, axboe@kernel.dk, martin.petersen@oracle.com, linux-nvme@lists.infradead.org, keith.busch@intel.com, hch@lst.de, sagi@grimberg.me, shlomin@mellanox.com, israelr@mellanox.com Subject: Re: [PATCH 2/4] nvme-rdma: simplify error flow in nvme_rdma_queue_rq Message-ID: <20190904055126.GC10553@lst.de> References: <1567523655-23989-1-git-send-email-maxg@mellanox.com> <1567523655-23989-2-git-send-email-maxg@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567523655-23989-2-git-send-email-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Sep 03, 2019 at 06:14:13PM +0300, Max Gurtovoy wrote: > Make the error flow symmetric to the good flow by moving the call to > nvme_cleanup_cmd from nvme_rdma_unmap_data function. > > Signed-off-by: Max Gurtovoy Looks good, and also independent from the PI changes: Reviewed-by: Christoph Hellwig