From: Fam Zheng <fam@euphon.net>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Pavel Begunkov (Silence)" <asml.silence@gmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bfq: Fix bfq linkage error
Date: Mon, 16 Sep 2019 14:22:42 +0800 [thread overview]
Message-ID: <20190916062242.GA25284@magic> (raw)
In-Reply-To: <333de59c-d4ca-3bc2-fffa-35d60bd14126@kernel.dk>
On Sat, 09/14 11:32, Jens Axboe wrote:
> On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote:
> > From: Pavel Begunkov <asml.silence@gmail.com>
> >
> > Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses
> > blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it
> > causes linkage error if bfq compiled as a module.
>
> Thanks, I'll apply and add the Fixes tag.
Thanks! This is indeed my oversight.
Fam
prev parent reply other threads:[~2019-09-16 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 17:31 [PATCH] bfq: Fix bfq linkage error Pavel Begunkov (Silence)
2019-09-14 17:32 ` Jens Axboe
2019-09-16 6:22 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916062242.GA25284@magic \
--to=fam@euphon.net \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).