From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA46C49ED7 for ; Mon, 16 Sep 2019 07:51:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7581D20650 for ; Mon, 16 Sep 2019 07:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725912AbfIPHv4 (ORCPT ); Mon, 16 Sep 2019 03:51:56 -0400 Received: from verein.lst.de ([213.95.11.211]:42930 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725847AbfIPHvz (ORCPT ); Mon, 16 Sep 2019 03:51:55 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 2AE1668B05; Mon, 16 Sep 2019 09:51:52 +0200 (CEST) Date: Mon, 16 Sep 2019 09:51:51 +0200 From: Christoph Hellwig To: Max Gurtovoy Cc: linux-block@vger.kernel.org, axboe@kernel.dk, martin.petersen@oracle.com, linux-nvme@lists.infradead.org, keith.busch@intel.com, hch@lst.de, sagi@grimberg.me, shlomin@mellanox.com, israelr@mellanox.com Subject: Re: [PATCH v6 1/2] block: use symbolic constants for t10_pi type Message-ID: <20190916075151.GA25796@lst.de> References: <1568493253-18142-1-git-send-email-maxg@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1568493253-18142-1-git-send-email-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Sep 14, 2019 at 11:34:12PM +0300, Max Gurtovoy wrote: > Reviewed-by: Martin K. Petersen > Signed-off-by: Max Gurtovoy A little bit of a changelog would have been nice, but otherwise this looks fine to me: Reviewed-by: Christoph Hellwig