From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
xiubli@redhat.com, josef@toxicpanda.com, mchristi@redhat.com,
linux-block@vger.kernel.org
Subject: Re: [PATCHv2 0/2] blk-mq: Avoid memory reclaim when allocating request map
Date: Wed, 18 Sep 2019 09:38:26 -0700 [thread overview]
Message-ID: <20190918163826.GA14377@infradead.org> (raw)
In-Reply-To: <8c08e9f8-cf71-8fcc-cff3-0d92dd859a59@kernel.dk>
On Mon, Sep 16, 2019 at 10:52:33AM -0600, Jens Axboe wrote:
> On 9/16/19 3:06 AM, Christoph Hellwig wrote:
> > On Mon, Sep 16, 2019 at 07:46:29AM +0530, xiubli@redhat.com wrote:
> >> From: Xiubo Li <xiubli@redhat.com>
> >>
> >> To make the patch more readable and cleaner I just split them into 2
> >> small ones to address the issue from @Ming Lei, thanks very much.
> >
> > I'd be much happier to just see memalloc_noio_save +
> > memalloc_noio_restore calls in the right places over sprinkling even
> > more magic GFP_NOIO arguments.
>
> Ugh, I always thought those were kind of lame and band aiding around
> places where people are too lazy to fix the path to the gfp args.
> Or maybe areas where it's just feasible.
The way I understood the discussion around the introduction of these
flags is that we want to phase out GFP_NOIO and GFP_NOFS in the long
run, given that ammending all calls is basically impossibly, while
marking contexts is pretty easy.
next prev parent reply other threads:[~2019-09-18 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 2:16 [PATCHv2 0/2] blk-mq: Avoid memory reclaim when allocating request map xiubli
2019-09-16 2:16 ` [PATCHv2 1/2] " xiubli
2019-09-16 2:16 ` [PATCHv2 2/2] blk-mq: use BLK_MQ_GFP_FLAGS macro instead xiubli
2019-09-16 9:06 ` [PATCHv2 0/2] blk-mq: Avoid memory reclaim when allocating request map Christoph Hellwig
2019-09-16 10:40 ` Xiubo Li
2019-09-16 16:52 ` Jens Axboe
2019-09-18 16:38 ` Christoph Hellwig [this message]
2019-09-25 7:05 ` Xiubo Li
2019-09-17 15:59 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918163826.GA14377@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).