From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH] fs/iomap: remove redundant check in iomap_dio_rw()
Date: Tue, 29 Oct 2019 09:14:52 -0700 [thread overview]
Message-ID: <20191029161452.GC15222@magnolia> (raw)
In-Reply-To: <1572342047-99933-1-git-send-email-joseph.qi@linux.alibaba.com>
On Tue, Oct 29, 2019 at 05:40:47PM +0800, Joseph Qi wrote:
> We've already check if it is READ iov_iter, no need check again.
>
> Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Applied to the iomap tree, thanks.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/iomap/direct-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index 1fc28c2..9712648 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -430,7 +430,7 @@ static void iomap_dio_bio_end_io(struct bio *bio)
> if (pos >= dio->i_size)
> goto out_free_dio;
>
> - if (iter_is_iovec(iter) && iov_iter_rw(iter) == READ)
> + if (iter_is_iovec(iter))
> dio->flags |= IOMAP_DIO_DIRTY;
> } else {
> flags |= IOMAP_WRITE;
> --
> 1.8.3.1
>
prev parent reply other threads:[~2019-10-29 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 9:40 [PATCH] fs/iomap: remove redundant check in iomap_dio_rw() Joseph Qi
2019-10-29 9:45 ` Johannes Thumshirn
2019-10-29 16:11 ` Jens Axboe
2019-10-29 16:14 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029161452.GC15222@magnolia \
--to=darrick.wong@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox