From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B84C43331 for ; Tue, 12 Nov 2019 08:32:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B3B92196E for ; Tue, 12 Nov 2019 08:32:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lZgfxhZy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726957AbfKLIcS (ORCPT ); Tue, 12 Nov 2019 03:32:18 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:55830 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbfKLIcS (ORCPT ); Tue, 12 Nov 2019 03:32:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PnZ2Xv5QzU531/DlEw36PKsM1WpetiqrlbT9IG3dL8k=; b=lZgfxhZyE0dP0kDFJj9ftdq3e yq8njdAiJAJmROqgXXkjeet9Kq0VPAvIgJiknDR8CFlDh65AYeRy4/DWFKszRy5UZvB+NVTkxFawx gt7svXxxKHexXgxjyIWB2hiDL7DFwkmm4g0Jk7KQrySSF5ZhK1G67qeJBQ5/cvZ4HDJ2o5qFUye28 E8X7WbWG1gWSWYAB/gzK5+dNVZsyE5JmXRiGkXEdxB7qCWan9PaQaO9vIjJz/xkb4Vz44vpqY3+4O QVkGADHTKd/G7ObvDP/VTZiUZ56B4RnVWkwZr74pytebO/unRAAsmSRv8Fq+FxeupcziqAT8pJVj5 aDwz1CXFg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURaq-0001FL-To; Tue, 12 Nov 2019 08:32:08 +0000 Date: Tue, 12 Nov 2019 00:32:08 -0800 From: Christoph Hellwig To: Evan Green Cc: Jens Axboe , Martin K Petersen , Gwendal Grignou , Ming Lei , "Darrick J . Wong" , Alexis Savery , Douglas Anderson , Bart Van Assche , Chaitanya Kulkarni , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/2] loop: Report EOPNOTSUPP properly Message-ID: <20191112083208.GA1848@infradead.org> References: <20191111185030.215451-1-evgreen@chromium.org> <20191111185030.215451-2-evgreen@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111185030.215451-2-evgreen@chromium.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Nov 11, 2019 at 10:50:29AM -0800, Evan Green wrote: > - if (cmd->ret < 0) > + if (cmd->ret == -EOPNOTSUPP) > + ret = BLK_STS_NOTSUPP; > + else if (cmd->ret < 0) > ret = BLK_STS_IOERR; This really should use errno_to_blk_status. Same for the other hunk.