From: Christoph Hellwig <hch@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
syzbot+21cfe1f803e0e158acf1@syzkaller.appspotmail.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Replace bio_check_ro()'s WARN_ON()
Date: Mon, 25 Nov 2019 09:40:37 -0800 [thread overview]
Message-ID: <20191125174037.GA768@infradead.org> (raw)
In-Reply-To: <201911221131.A34DFAA49@keescook>
So I looked at this a bit, and doing the right thing (TM) will be
a little invase and thus not for 5.5.
But the 5.5. queue already has a patch from Mikulas Patocka:
8b2ded1c94c ("block: don't warn when doing fsync on read-only devices")
which should deal with this issue, and in fact I can't trigger the
WARN_ON with Jens' latest tree.
prev parent reply other threads:[~2019-11-25 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 21:15 [PATCH] block: Replace bio_check_ro()'s WARN_ON() Kees Cook
2019-11-22 18:53 ` Kees Cook
2019-11-22 18:55 ` Jens Axboe
2019-11-22 18:57 ` Kees Cook
2019-11-22 19:07 ` Christoph Hellwig
2019-11-22 19:09 ` Jens Axboe
2019-11-22 19:14 ` Christoph Hellwig
2019-11-22 19:34 ` Kees Cook
2019-11-25 17:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125174037.GA768@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+21cfe1f803e0e158acf1@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).