From: Pavel Machek <pavel@denx.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Christoph Hellwig <hch@lst.de>, Faiz Abbas <faiz_abbas@ti.com>,
linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 240/321] mmc: core: align max segment size with logical block size
Date: Thu, 5 Dec 2019 23:22:47 +0100 [thread overview]
Message-ID: <20191205222247.GC25107@duo.ucw.cz> (raw)
In-Reply-To: <20191203223439.627632861@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
Hi!
> From: Ming Lei <ming.lei@redhat.com>
>
> [ Upstream commit c53336c8f5f29043fded57912cc06c24e12613d7 ]
>
> Logical block size is the lowest possible block size that the storage
> device can address. Max segment size is often related with controller's
> DMA capability. And it is reasonable to align max segment size with
> logical block size.
> SDHCI sets un-aligned max segment size, and causes ADMA error, so
> fix it by aligning max segment size with logical block size.
If un-aligned max segment sizes are problem, should we add checks to
prevent setting them?
At least these set unaligned problems; is that a problem?
drivers/block/nbd.c: blk_queue_max_segment_size(disk->queue, UINT_MAX);
drivers/block/virtio_blk.c: blk_queue_max_segment_size(q, -1U);
drivers/block/rbd.c: blk_queue_max_segment_size(q, UINT_MAX);
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2019-12-05 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191203223427.103571230@linuxfoundation.org>
2019-12-03 22:35 ` [PATCH 4.19 240/321] mmc: core: align max segment size with logical block size Greg Kroah-Hartman
2019-12-05 22:22 ` Pavel Machek [this message]
2019-12-06 0:54 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205222247.GC25107@duo.ucw.cz \
--to=pavel@denx.de \
--cc=faiz_abbas@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox