From: Christoph Hellwig <hch@lst.de>
To: Liang C <liangchen.linux@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Coly Li <colyli@suse.de>,
Kent Overstreet <kent.overstreet@gmail.com>,
linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: bcache kbuild cleanups
Date: Thu, 12 Dec 2019 16:34:30 +0100 [thread overview]
Message-ID: <20191212153430.GA10543@lst.de> (raw)
In-Reply-To: <CAKhg4tJGWwm5cTkctuch-ACrDOLfLKK8HCCTcJZPF2iURc9rUg@mail.gmail.com>
On Wed, Dec 11, 2019 at 11:17:44PM +0800, Liang C wrote:
> > Hi Coly and Liang,
> >
> > can you review this series to sort out the bcache superblock reading for
> > larger page sizes? I don't have bcache test setup so this is compile
> > tested only.
> >
> Hi Christoph,
>
> Thanks for making the patches. I looked through them, but didn't see
> where cache and cached_dev have their sb_disk assigned.
> That would be an issue when __write_super tries to add the
> corresponding page to the bio. Not sure if there is there anything I
> missed.
Yes, that was missing.
next prev parent reply other threads:[~2019-12-12 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 9:38 bcache kbuild cleanups Christoph Hellwig
2019-12-09 9:38 ` [PATCH 1/7] bcache: cached_dev_free needs to put the sb page Christoph Hellwig
2019-12-09 9:38 ` [PATCH 2/7] bcache: use a separate data structure for the on-disk super block Christoph Hellwig
2019-12-09 9:38 ` [PATCH 3/7] bcache: rework error unwinding in register_bcache Christoph Hellwig
2019-12-09 9:38 ` [PATCH 4/7] bcache: transfer the sb_page reference to register_{bdev,cache} Christoph Hellwig
2019-12-09 9:38 ` [PATCH 5/7] bcache: return a pointer to the on-disk sb from read_super Christoph Hellwig
2019-12-09 9:38 ` [PATCH 6/7] bcache: store a pointer to the on-disk sb in the cache and cached_dev structures Christoph Hellwig
2019-12-09 9:38 ` [PATCH 7/7] bcache: use read_cache_page_gfp to read the superblock Christoph Hellwig
2019-12-09 9:59 ` bcache kbuild cleanups Coly Li
2019-12-11 15:17 ` Liang C
2019-12-12 15:34 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-15 16:04 Christoph Hellwig
2019-10-20 6:24 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212153430.GA10543@lst.de \
--to=hch@lst.de \
--cc=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=liangchen.linux@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox