* [PATCH] block: remove unused mp_bvec_last_segment
@ 2020-01-04 17:43 Jens Axboe
2020-01-05 0:49 ` Ming Lei
0 siblings, 1 reply; 2+ messages in thread
From: Jens Axboe @ 2020-01-04 17:43 UTC (permalink / raw)
To: linux-block@vger.kernel.org; +Cc: Ming Lei
After commit 85a8ce62c2ea ("block: add bio_truncate to fix guard_bio_eod")
this function is unused, remove it.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index 679a42253170..a81c13ac1972 100644
--- a/include/linux/bvec.h
+++ b/include/linux/bvec.h
@@ -153,26 +153,4 @@ static inline void bvec_advance(const struct bio_vec *bvec,
}
}
-/*
- * Get the last single-page segment from the multi-page bvec and store it
- * in @seg
- */
-static inline void mp_bvec_last_segment(const struct bio_vec *bvec,
- struct bio_vec *seg)
-{
- unsigned total = bvec->bv_offset + bvec->bv_len;
- unsigned last_page = (total - 1) / PAGE_SIZE;
-
- seg->bv_page = bvec->bv_page + last_page;
-
- /* the whole segment is inside the last page */
- if (bvec->bv_offset >= last_page * PAGE_SIZE) {
- seg->bv_offset = bvec->bv_offset % PAGE_SIZE;
- seg->bv_len = bvec->bv_len;
- } else {
- seg->bv_offset = 0;
- seg->bv_len = total - last_page * PAGE_SIZE;
- }
-}
-
#endif /* __LINUX_BVEC_ITER_H */
--
Jens Axboe
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: remove unused mp_bvec_last_segment
2020-01-04 17:43 [PATCH] block: remove unused mp_bvec_last_segment Jens Axboe
@ 2020-01-05 0:49 ` Ming Lei
0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2020-01-05 0:49 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block@vger.kernel.org
On Sat, Jan 04, 2020 at 10:43:09AM -0700, Jens Axboe wrote:
> After commit 85a8ce62c2ea ("block: add bio_truncate to fix guard_bio_eod")
> this function is unused, remove it.
>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> ---
>
> diff --git a/include/linux/bvec.h b/include/linux/bvec.h
> index 679a42253170..a81c13ac1972 100644
> --- a/include/linux/bvec.h
> +++ b/include/linux/bvec.h
> @@ -153,26 +153,4 @@ static inline void bvec_advance(const struct bio_vec *bvec,
> }
> }
>
> -/*
> - * Get the last single-page segment from the multi-page bvec and store it
> - * in @seg
> - */
> -static inline void mp_bvec_last_segment(const struct bio_vec *bvec,
> - struct bio_vec *seg)
> -{
> - unsigned total = bvec->bv_offset + bvec->bv_len;
> - unsigned last_page = (total - 1) / PAGE_SIZE;
> -
> - seg->bv_page = bvec->bv_page + last_page;
> -
> - /* the whole segment is inside the last page */
> - if (bvec->bv_offset >= last_page * PAGE_SIZE) {
> - seg->bv_offset = bvec->bv_offset % PAGE_SIZE;
> - seg->bv_len = bvec->bv_len;
> - } else {
> - seg->bv_offset = 0;
> - seg->bv_len = total - last_page * PAGE_SIZE;
> - }
> -}
> -
> #endif /* __LINUX_BVEC_ITER_H */
>
> --
> Jens Axboe
>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-05 0:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-04 17:43 [PATCH] block: remove unused mp_bvec_last_segment Jens Axboe
2020-01-05 0:49 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).