From: Christoph Hellwig <hch@infradead.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] block: Allow t10-pi to be modular
Date: Wed, 8 Jan 2020 05:39:47 -0800 [thread overview]
Message-ID: <20200108133947.GD4455@infradead.org> (raw)
In-Reply-To: <20191223081351.gsunwl6zwcltfdy6@gondor.apana.org.au>
On Mon, Dec 23, 2019 at 04:13:51PM +0800, Herbert Xu wrote:
> Currently t10-pi can only be built into the block layer which via
> crc-t10dif pulls in a whole chunk of the Crypto API. In fact all
> users of t10-pi work as modules and there is no reason for it to
> always be built-in.
>
> This patch adds a new hidden option for t10-pi that is selected
> automatically based on BLK_DEV_INTEGRITY and whether the users
> of t10-pi are built-in or not.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-01-08 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 8:13 [PATCH] block: Allow t10-pi to be modular Herbert Xu
2020-01-07 3:25 ` Martin K. Petersen
2020-01-07 3:59 ` Jens Axboe
2020-01-08 13:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108133947.GD4455@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=herbert@gondor.apana.org.au \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).