From: Klaus Jensen <k.jensen@samsung.com>
To: <linux-block@vger.kernel.org>
Cc: <osandov@fb.com>, <its@irrelevant.dk>
Subject: [PATCH blktests] common/fio: do not use norandommap with verify
Date: Thu, 30 Jan 2020 09:49:41 +0100 [thread overview]
Message-ID: <20200130084941.60943-1-k.jensen@samsung.com> (raw)
In-Reply-To: CGME20200130084950eucas1p2dac69024658d531d5f69ea0bdbd2be81@eucas1p2.samsung.com
As per the fio documentation, using norandommap with an async I/O engine
and I/O depth > 1, can cause verification errors.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
common/fio | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/fio b/common/fio
index 2e81b26b50f1..8bfad4238dda 100644
--- a/common/fio
+++ b/common/fio
@@ -180,7 +180,7 @@ _run_fio_rand_io() {
_run_fio_verify_io() {
_run_fio --name=verify --rw=randwrite --direct=1 --ioengine=libaio --bs=4k \
- --norandommap --iodepth=16 --verify=crc32c "$@"
+ --iodepth=16 --verify=crc32c "$@"
}
_fio_perf_report() {
--
2.25.0
next parent reply other threads:[~2020-01-30 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200130084950eucas1p2dac69024658d531d5f69ea0bdbd2be81@eucas1p2.samsung.com>
2020-01-30 8:49 ` Klaus Jensen [this message]
2020-02-03 21:43 ` [PATCH blktests] common/fio: do not use norandommap with verify Omar Sandoval
2020-04-02 11:25 ` Klaus Birkelund Jensen
2020-04-03 18:20 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130084941.60943-1-k.jensen@samsung.com \
--to=k.jensen@samsung.com \
--cc=its@irrelevant.dk \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox