Re: [PATCH 01/10] sbitmap: maintain allocation round_robin in sbitmap

Hannes Reinecke
2020-04-14T06:04:51Z

On 2/11/20 1:11 PM, Ming Lei wrote:
> Now allocation round_robin info is maintained by sbitmap_queue.
>
> Actually, bit allocation belongs to sbitmap. Also the following
> patch will move alloc_hint to sbitmap for users with high depth.
>
> So move round_robin to sbitmap.
>
> Cc: Omar Sandoval <osandov@fb.com>
> Cc: Sathya Prakash <sathya.prakash@broadcom.com>
> Cc: Chaitra P B <chaitra.basappa@broadcom.com>
> Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
> Cc: Kashyap Desai <kashyap.desai@broadcom.com>
> Cc: Sumit Saxena <sumit.saxena@broadcom.com>
> Cc: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
> Cc: Ewan D. Milne <emilne@redhat.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Bart Van Assche <bart.vanassche@wdc.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> block/blk-mq.c | 2 +-
> block/kyber-iosched.c | 3 ++-
> drivers/dma/idxd/device.c | 2 +-
> drivers/dma/idxd/submit.c | 2 +-
> include/linux/sbitmap.h | 20 ++++++++++----------
> lib/sbitmap.c | 28 ++++++++++++++--------------
> 6 files changed, 29 insertions(+), 28 deletions(-)
> Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer