From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B3A8C11D00 for ; Thu, 20 Feb 2020 22:02:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07EC2208E4 for ; Thu, 20 Feb 2020 22:02:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="1sM+flAa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727801AbgBTWCl (ORCPT ); Thu, 20 Feb 2020 17:02:41 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:34380 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727786AbgBTWCl (ORCPT ); Thu, 20 Feb 2020 17:02:41 -0500 Received: by mail-qk1-f195.google.com with SMTP id c20so67310qkm.1 for ; Thu, 20 Feb 2020 14:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qs+LhNiBMIj9A7PLEkqadpwwdn4t7ZJVTcZjDGn03PM=; b=1sM+flAalAjdf9H+ABF4RBpnc7mgf/EB1PkQ3GIvPhatEPuYG/+kZZYytUx2breYo9 oBS4Cz3/NHUDHKrF1wClmlsU2wMQWRh9jUeUVFlKDnYU1XDy2DbPjMAN6/dFKk+WparC n2mnFSbEJsFPwZS1Vkfj9gnphTLnT9mqRYcdYb3mcnuK5c108UQ0b24WLrAoGSNFpyha iPLMyEc4PN5W+kfi2o4BOepzuEVVQ0MwF8HwWATiYKm8p4b2uSETdNaNTVOHwu7ULX5K 9cl6gc557oQYGhjYLQyYi1BtFt0PWyzSVcxVJSRFwVQAzbgf64CESMf7EXkdNMTvkNc/ T1Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qs+LhNiBMIj9A7PLEkqadpwwdn4t7ZJVTcZjDGn03PM=; b=qVLCAyYhE6B+6/kdP7HQD2cS6To/089fjXlj5kGb9/hJpH02pizUv/y58a1Ff12o+/ hLc2eBY/RaRxXwIpKQFD6vPREfh64JGoRXFOWjMcmzz0CjtWUH117znrj/OUDRkgYgiK HlY/5vChGUp/IE5OtW34Ed8WCQpbzde43mfqLVZxtW/f/xgXkt5wdax0X8RGzYu99JyU P3Leb4iY/S5p+JwM6O7UzRJZIL+9PxNBAFR34IQtRVqFlNOL8oi4tTeIWtvBoqhmg7IV I29dzvKeYlNvvE7ZidJvPu5uexCRbKGEJSIVRXLepI57QDTn/EkoTVH+CS5/skD0FF/j g/mw== X-Gm-Message-State: APjAAAURoV7yUYtSlw49f22nHyabtrspUZx5xIounkTtuuIZBCsBBO0O yi/60z9d+DdYgRF2NHQhVyyVPQ== X-Google-Smtp-Source: APXvYqzeLjYnxMcLPrrXE8eCyXI/Ol0Il3CHL5hbzaE2ieHBb3/wY1MEQ7PKwGJEA0oW/FVjRgCOZA== X-Received: by 2002:a05:620a:1037:: with SMTP id a23mr29030822qkk.82.1582236160287; Thu, 20 Feb 2020 14:02:40 -0800 (PST) Received: from localhost ([2620:10d:c091:500::1:3504]) by smtp.gmail.com with ESMTPSA id e16sm518875qkl.32.2020.02.20.14.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 14:02:39 -0800 (PST) Date: Thu, 20 Feb 2020 17:02:38 -0500 From: Johannes Weiner To: Dan Schatzberg Cc: Jens Axboe , Tejun Heo , Li Zefan , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Roman Gushchin , Shakeel Butt , Chris Down , Yang Shi , Thomas Gleixner , "open list:BLOCK LAYER" , open list , "open list:CONTROL GROUP (CGROUP)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Subject: Re: [PATCH v3 3/3] loop: Charge i/o to mem and blk cg Message-ID: <20200220220238.GB68937@cmpxchg.org> References: <78060dcbf6578b4da6081f9f48b24b33726c5083.1582216295.git.schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78060dcbf6578b4da6081f9f48b24b33726c5083.1582216295.git.schatzberg.dan@gmail.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Feb 20, 2020 at 11:51:53AM -0500, Dan Schatzberg wrote: > The current code only associates with the existing blkcg when aio is > used to access the backing file. This patch covers all types of i/o to > the backing file and also associates the memcg so if the backing file is > on tmpfs, memory is charged appropriately. > > This patch also exports cgroup_get_e_css so it can be used by the loop > module. > > Signed-off-by: Dan Schatzberg The cgroup bits look good to me. Acked-by: Johannes Weiner