From: Greg KH <gregkh@linuxfoundation.org>
To: Cengiz Can <cengiz@kernel.wtf>
Cc: kbusch@kernel.org, Chaitanya.Kulkarni@wdc.com, axboe@kernel.dk,
helgaas@kernel.org, jack@suse.cz, linux-block@vger.kernel.org,
stable@vger.kernel.org, tristmd@gmail.com
Subject: Re: [PATCH] blktrace: Protect q->blk_trace with RCU
Date: Tue, 3 Mar 2020 13:17:41 +0100 [thread overview]
Message-ID: <20200303121741.GA2021063@kroah.com> (raw)
In-Reply-To: <20200303110731.65552-1-cengiz@kernel.wtf>
On Tue, Mar 03, 2020 at 02:07:32PM +0300, Cengiz Can wrote:
> Added a reassignment into the NULL check block to fix the issue.
>
> Fixes: c780e86dd48 ("blktrace: Protect q->blk_trace with RCU")
>
> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
> ---
> kernel/trace/blktrace.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 4560878f0bac..29ea88f10b87 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -1896,8 +1896,10 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
> }
>
> ret = 0;
> - if (bt == NULL)
> + if (bt == NULL) {
> ret = blk_trace_setup_queue(q, bdev);
> + bt = q->blk_trace;
> + }
>
> if (ret == 0) {
> if (attr == &dev_attr_act_mask)
> --
> 2.25.1
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2020-03-03 12:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 14:28 [PATCH] blktrace: Protect q->blk_trace with RCU Jan Kara
2020-02-06 18:46 ` Chaitanya Kulkarni
2020-02-06 18:49 ` Jens Axboe
2020-02-06 19:37 ` Chaitanya Kulkarni
2020-02-10 0:38 ` Chaitanya Kulkarni
2020-02-10 2:19 ` Ming Lei
2020-02-10 3:54 ` Bart Van Assche
2020-02-19 12:59 ` Jan Kara
2020-02-25 10:20 ` Ming Lei
2020-02-25 15:40 ` Jens Axboe
2020-03-02 20:40 ` Bjorn Helgaas
2020-03-02 21:19 ` Chaitanya Kulkarni
2020-03-02 21:59 ` Bjorn Helgaas
2020-03-02 22:06 ` Keith Busch
2020-03-03 11:07 ` Cengiz Can
2020-03-03 12:17 ` Greg KH [this message]
2020-03-05 1:51 ` Ming Lei
2020-03-05 4:27 ` Cengiz Can
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303121741.GA2021063@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=cengiz@kernel.wtf \
--cc=helgaas@kernel.org \
--cc=jack@suse.cz \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tristmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox