From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>,
"Bart Van Assche" <bvanassche@acm.org>,
"André Almeida" <andrealmeid@collabora.com>,
"Chaitanya Kulkarni" <chaitanya.kulkarni@wdc.com>
Subject: [PATCH v4 1/8] blk-mq: Fix a comment in include/linux/blk-mq.h
Date: Mon, 9 Mar 2020 21:26:16 -0700 [thread overview]
Message-ID: <20200310042623.20779-2-bvanassche@acm.org> (raw)
In-Reply-To: <20200310042623.20779-1-bvanassche@acm.org>
The 'hctx_list' member of struct blk_mq_hw_ctx is not a list head but
instead an entry in q->unused_hctx_list. Fix the comment above this
struct member.
Cc: André Almeida <andrealmeid@collabora.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Fixes: d386732bc142 ("blk-mq: fill header with kernel-doc")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
include/linux/blk-mq.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 11cfd6470b1a..31344d5f83e2 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -162,7 +162,10 @@ struct blk_mq_hw_ctx {
struct dentry *sched_debugfs_dir;
#endif
- /** @hctx_list: List of all hardware queues. */
+ /**
+ * @hctx_list: if this hctx is not in use, this is an entry in
+ * q->unused_hctx_list.
+ */
struct list_head hctx_list;
/**
next prev parent reply other threads:[~2020-03-10 4:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 4:26 [PATCH v4 0/8] Improve changing the number of hardware queues Bart Van Assche
2020-03-10 4:26 ` Bart Van Assche [this message]
2020-03-10 4:26 ` [PATCH v4 2/8] blk-mq: Keep set->nr_hw_queues and set->map[].nr_queues in sync Bart Van Assche
2020-03-10 4:26 ` [PATCH v4 3/8] blk-mq: Fix a recently introduced regression in blk_mq_realloc_hw_ctxs() Bart Van Assche
2020-03-10 4:26 ` [PATCH v4 4/8] null_blk: Suppress an UBSAN complaint triggered when setting 'memory_backed' Bart Van Assche
2020-03-10 4:26 ` [PATCH v4 5/8] null_blk: Fix changing the number of hardware queues Bart Van Assche
2020-03-10 4:26 ` [PATCH v4 6/8] null_blk: Fix the null_add_dev() error path Bart Van Assche
2020-03-10 4:26 ` [PATCH v4 7/8] null_blk: Handle null_add_dev() failures properly Bart Van Assche
2020-03-10 4:26 ` [PATCH v4 8/8] null_blk: Add support for init_hctx() fault injection Bart Van Assche
2020-03-10 13:10 ` [PATCH v4 0/8] Improve changing the number of hardware queues Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310042623.20779-2-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=andrealmeid@collabora.com \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).