From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Barani Muthukumaran <bmuthuku@qti.qualcomm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-fscrypt@vger.kernel.org" <linux-fscrypt@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Andy Gross <agross@kernel.org>, Avri Altman <avri.altman@wdc.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
Can Guo <cang@codeaurora.org>,
Elliot Berman <eberman@codeaurora.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Satya Tangirala <satyat@google.com>
Subject: Re: [RFC PATCH v3 4/4] scsi: ufs-qcom: add Inline Crypto Engine support
Date: Thu, 19 Mar 2020 03:33:42 -0700 [thread overview]
Message-ID: <20200319103342.GB30601@infradead.org> (raw)
In-Reply-To: <20200312190541.GB6470@sol.localdomain>
On Thu, Mar 12, 2020 at 12:05:41PM -0700, Eric Biggers wrote:
> Of course, if someone actually posts patches to support hardware that diverges
> from the UFS standard in new and "exciting" ways (whether it's another vendor's
> hardware or future Qualcomm hardware) then they'll need to post any variant
> operation(s) they need. They need to be targetted to only the specific quirk(s)
> needed, so that drivers don't have to unnecessarily re-implement stuff.
I think the only sane answer is that we only support hardware upstream
that conforms to the standard and we skip all that bullshit. The whole
point of the standard is that things just work, and we should not give
vendors a wild card to come up with bullshit like the interfaces handled
in this patchset.
prev parent reply other threads:[~2020-03-19 10:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 17:12 [RFC PATCH v3 0/4] Inline crypto support on DragonBoard 845c Eric Biggers
2020-03-12 17:12 ` [RFC PATCH v3 1/4] firmware: qcom_scm: Add support for programming inline crypto keys Eric Biggers
2020-03-12 17:12 ` [RFC PATCH v3 2/4] arm64: dts: sdm845: add Inline Crypto Engine registers and clock Eric Biggers
2020-03-12 17:12 ` [RFC PATCH v3 3/4] scsi: ufs: add program_key() variant op Eric Biggers
2020-03-12 17:12 ` [RFC PATCH v3 4/4] scsi: ufs-qcom: add Inline Crypto Engine support Eric Biggers
2020-03-12 18:21 ` Barani Muthukumaran
2020-03-12 19:05 ` Eric Biggers
2020-03-13 17:05 ` Barani Muthukumaran
2020-03-13 17:37 ` Eric Biggers
2020-03-19 10:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319103342.GB30601@infradead.org \
--to=hch@infradead.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bjorn.andersson@linaro.org \
--cc=bmuthuku@qti.qualcomm.com \
--cc=cang@codeaurora.org \
--cc=eberman@codeaurora.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox