From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB460C2D0EE for ; Thu, 26 Mar 2020 14:52:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B49E820775 for ; Thu, 26 Mar 2020 14:52:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bjwScgOJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727732AbgCZOwy (ORCPT ); Thu, 26 Mar 2020 10:52:54 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37704 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726363AbgCZOwy (ORCPT ); Thu, 26 Mar 2020 10:52:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nqEnebPIOi5SsqyCoU4xaoU1x1rSsF2tTFTUij9Ifa4=; b=bjwScgOJIAMEqY8jcdd2lfpuQP LplYlXmWmFAJh5lLSOSNIPIgAz4J44Rc/K0K1VLqsCo5HvGFvN0edUuQOOrge1sGMwMhY3TToSYox 5WGTcRWPkglPPWTj4wl0JG31YU7Z4teKIRus8rfnl/hIucEKvNeSC3/j738iHJf0rdetC9YNxUZrL wQdruZZYWnAj1H6iG1MtMuevtrKAI+rRy1tEj1WxsrzLGbFqC+aCbSfXEgWb58kko+35h3Hvf/weu +OXbm4v5pTC7oAZGik1aBFh0D+sUOsoJO2JfbjeoO4HTzZ/FncT91mDDoeFr2z9Xl3xjRTzmB0YvS chbNmWsw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHTsL-00051u-OY; Thu, 26 Mar 2020 14:52:53 +0000 Date: Thu, 26 Mar 2020 07:52:53 -0700 From: Christoph Hellwig To: Andrzej Pietrasiewicz Cc: linux-block@vger.kernel.org, Jens Axboe , kernel@collabora.com, Evan Green Subject: Re: [PATCH RESEND 1/2] loop: Report EOPNOTSUPP properly Message-ID: <20200326145253.GA18623@infradead.org> References: <20200317151111.25749-2-andrzej.p@collabora.com> <20200317165106.29282-1-andrzej.p@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317165106.29282-1-andrzej.p@collabora.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Mar 17, 2020 at 05:51:06PM +0100, Andrzej Pietrasiewicz wrote: > From: Evan Green > > Properly plumb out EOPNOTSUPP from loop driver operations, which may > get returned when for instance a discard operation is attempted but not > supported by the underlying block device. Before this change, everything > was reported in the log as an I/O error, which is scary and not > helpful in debugging. This really should be using errno_to_blk_status.