From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06018C43331 for ; Sat, 28 Mar 2020 08:22:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDEC520714 for ; Sat, 28 Mar 2020 08:22:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XgREbhzM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725947AbgC1IWL (ORCPT ); Sat, 28 Mar 2020 04:22:11 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42486 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbgC1IWL (ORCPT ); Sat, 28 Mar 2020 04:22:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Nc888JpTgVIfXX5tVvoxp3UN2s0cRXynP/qnhs+Hwy8=; b=XgREbhzMpd5HkrKpjlA9cUGtI4 4hrjvagAsWRvqxflM0ZOOp37ytOqLDqdHGM3TmPC9J4udmf9PP8TNUgXLWN53JolNW8IbFhCKzrcT yYEn5scJryTgbBqG1AikejxeLjdJHMyxi7NBBkKfLz82O4UZHPLSwDOx24/XaOJGWBPgotRX4KbQY RhJrhgExxOsohYGnNDW9CugnMYka/pC7MV4gx54fmWMoVZcGiwcdM9/MfH8QPRPQigzctr1oYR61V 1M72svYro5cesUF4I9Qp9hqWmpVro95v5Tnp+53xyaM1Rk2iOV8zuRYL+KzLlSGijafaYps0G6tPB uqQcRrtw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jI6jL-0001sf-6l; Sat, 28 Mar 2020 08:22:11 +0000 Date: Sat, 28 Mar 2020 01:22:11 -0700 From: "hch@infradead.org" To: Damien Le Moal Cc: "hch@infradead.org" , "linux-block@vger.kernel.org" , Jens Axboe , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" Subject: Re: [PATCH] block: all zones zone management operations Message-ID: <20200328082211.GA32518@infradead.org> References: <20200326043012.600187-1-damien.lemoal@wdc.com> <20200326072800.GA21082@infradead.org> <20200326093049.GB6478@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Mar 28, 2020 at 08:13:26AM +0000, Damien Le Moal wrote: > In any case, I think that the patch has value as a nice cleanup of the reset vs > reset all request operations (the latter going away). The side effect of it > being that open/close/finish all come for free with it. I would like to get it > in just for this nice cleanup. Well, this keeps about the same amount of core code (and I'm not sure it really is cleaner) while adding significantly more code in sd and null_blk. Not my classic definition of a cleanup.