From: "hch@infradead.org" <hch@infradead.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] block: all zones zone management operations
Date: Sat, 28 Mar 2020 01:31:01 -0700 [thread overview]
Message-ID: <20200328083101.GA17417@infradead.org> (raw)
In-Reply-To: <CO2PR04MB234357A7ED343AD22375CD00E7CD0@CO2PR04MB2343.namprd04.prod.outlook.com>
On Sat, Mar 28, 2020 at 08:27:09AM +0000, Damien Le Moal wrote:
> On 2020/03/28 17:22, hch@infradead.org wrote:
> > On Sat, Mar 28, 2020 at 08:13:26AM +0000, Damien Le Moal wrote:
> >> In any case, I think that the patch has value as a nice cleanup of the reset vs
> >> reset all request operations (the latter going away). The side effect of it
> >> being that open/close/finish all come for free with it. I would like to get it
> >> in just for this nice cleanup.
> >
> > Well, this keeps about the same amount of core code (and I'm not sure
> > it really is cleaner) while adding significantly more code in sd and
> > null_blk. Not my classic definition of a cleanup.
>
> sd is simplified (one less argument for setup of zone mgmt commands). But yes,
> agreed that null_blk does need more code.
>
> OK. Let's drop this for now then.
FYI, if you think the flag is cleaner than a new op you could resubmit
this but keep the flag reset specific for now. That won't require new
code in null_blk for a use cases no callers uses anyway.
next prev parent reply other threads:[~2020-03-28 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 4:30 [PATCH] block: all zones zone management operations Damien Le Moal
2020-03-26 7:28 ` Christoph Hellwig
2020-03-26 8:23 ` Damien Le Moal
2020-03-26 9:30 ` hch
2020-03-28 8:13 ` Damien Le Moal
2020-03-28 8:22 ` hch
2020-03-28 8:27 ` Damien Le Moal
2020-03-28 8:31 ` hch [this message]
2020-03-28 8:37 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328083101.GA17417@infradead.org \
--to=hch@infradead.org \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox