From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC026C2BABC for ; Tue, 7 Apr 2020 09:29:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A297620719 for ; Tue, 7 Apr 2020 09:29:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PJbFQ8hL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728078AbgDGJ3e (ORCPT ); Tue, 7 Apr 2020 05:29:34 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:42450 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726353AbgDGJ3e (ORCPT ); Tue, 7 Apr 2020 05:29:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586251773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zsP627QYRtfwJA+BKFkDIVPFFxEyLIXkreoFWYVzFq4=; b=PJbFQ8hLr1qOQpTu1HCOpH87FMidLvSBEvFwljhBXjW14ecoW2zXgtfvcF8hliBohQUvLw Jcfe+TwC/XXumbQWbf976UQeyQJT4kDewljgFg6mYzk4Evz3xqVmmSfNpKvSgVxLNA2zd6 GWPRFuqlMYBw7MkxjsxOKzwb0XN8xlw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-oKI_W5fTOzWPjHwW6TR2kA-1; Tue, 07 Apr 2020 05:29:28 -0400 X-MC-Unique: oKI_W5fTOzWPjHwW6TR2kA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 41C0C149C0; Tue, 7 Apr 2020 09:29:27 +0000 (UTC) Received: from localhost (ovpn-8-23.pek2.redhat.com [10.72.8.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id A57BB272A0; Tue, 7 Apr 2020 09:29:23 +0000 (UTC) From: Ming Lei To: Jens Axboe Cc: linux-block@vger.kernel.org, Ming Lei , John Garry , Bart Van Assche , Hannes Reinecke , Christoph Hellwig , Thomas Gleixner Subject: [PATCH V6 3/8] blk-mq: prepare for draining IO when hctx's all CPUs are offline Date: Tue, 7 Apr 2020 17:28:56 +0800 Message-Id: <20200407092901.314228-4-ming.lei@redhat.com> In-Reply-To: <20200407092901.314228-1-ming.lei@redhat.com> References: <20200407092901.314228-1-ming.lei@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Content-Transfer-Encoding: quoted-printable Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Most of blk-mq drivers depend on managed IRQ's auto-affinity to setup up queue mapping. Thomas mentioned the following point[1]: " That was the constraint of managed interrupts from the very beginning: The driver/subsystem has to quiesce the interrupt line and the associat= ed queue _before_ it gets shutdown in CPU unplug and not fiddle with it until it's restarted by the core when the CPU is plugged in again. " However, current blk-mq implementation doesn't quiesce hw queue before the last CPU in the hctx is shutdown. Even worse, CPUHP_BLK_MQ_DEAD is one cpuhp state handled after the CPU is down, so there isn't any chance to quiesce hctx for blk-mq wrt. CPU hotplug. Add new cpuhp state of CPUHP_AP_BLK_MQ_ONLINE for blk-mq to stop queues and wait for completion of in-flight requests. We will stop hw queue and wait for completion of in-flight requests when one hctx is becoming dead in the following patch. This way may cause dead-lock for some stacking blk-mq drivers, such as dm-rq and loop. Add blk-mq flag of BLK_MQ_F_NO_MANAGED_IRQ and mark it for dm-rq and loop, so we needn't to wait for completion of in-flight requests from dm-rq & loop, then the potential dead-lock can be avoided. [1] https://lore.kernel.org/linux-block/alpine.DEB.2.21.1904051331270.180= 2@nanos.tec.linutronix.de/ Cc: John Garry Cc: Bart Van Assche Cc: Hannes Reinecke Cc: Christoph Hellwig Cc: Thomas Gleixner Signed-off-by: Ming Lei --- block/blk-mq-debugfs.c | 1 + block/blk-mq.c | 13 +++++++++++++ drivers/block/loop.c | 2 +- drivers/md/dm-rq.c | 2 +- include/linux/blk-mq.h | 3 +++ include/linux/cpuhotplug.h | 1 + 6 files changed, 20 insertions(+), 2 deletions(-) diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index d6de4f7f38cb..b62390918ca5 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -240,6 +240,7 @@ static const char *const hctx_flag_name[] =3D { HCTX_FLAG_NAME(TAG_SHARED), HCTX_FLAG_NAME(BLOCKING), HCTX_FLAG_NAME(NO_SCHED), + HCTX_FLAG_NAME(NO_MANAGED_IRQ), }; #undef HCTX_FLAG_NAME =20 diff --git a/block/blk-mq.c b/block/blk-mq.c index f6f1ba3ff783..4ee8695142c0 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2249,6 +2249,11 @@ int blk_mq_alloc_rqs(struct blk_mq_tag_set *set, s= truct blk_mq_tags *tags, return -ENOMEM; } =20 +static int blk_mq_hctx_notify_online(unsigned int cpu, struct hlist_node= *node) +{ + return 0; +} + /* * 'cpu' is going away. splice any existing rq_list entries from this * software queue to the hw queue dispatch list, and ensure that it @@ -2285,6 +2290,9 @@ static int blk_mq_hctx_notify_dead(unsigned int cpu= , struct hlist_node *node) =20 static void blk_mq_remove_cpuhp(struct blk_mq_hw_ctx *hctx) { + if (!(hctx->flags & BLK_MQ_F_NO_MANAGED_IRQ)) + cpuhp_state_remove_instance_nocalls(CPUHP_AP_BLK_MQ_ONLINE, + &hctx->cpuhp_online); cpuhp_state_remove_instance_nocalls(CPUHP_BLK_MQ_DEAD, &hctx->cpuhp_dead); } @@ -2344,6 +2352,9 @@ static int blk_mq_init_hctx(struct request_queue *q= , { hctx->queue_num =3D hctx_idx; =20 + if (!(hctx->flags & BLK_MQ_F_NO_MANAGED_IRQ)) + cpuhp_state_add_instance_nocalls(CPUHP_AP_BLK_MQ_ONLINE, + &hctx->cpuhp_online); cpuhp_state_add_instance_nocalls(CPUHP_BLK_MQ_DEAD, &hctx->cpuhp_dead); =20 hctx->tags =3D set->tags[hctx_idx]; @@ -3588,6 +3599,8 @@ static int __init blk_mq_init(void) { cpuhp_setup_state_multi(CPUHP_BLK_MQ_DEAD, "block/mq:dead", NULL, blk_mq_hctx_notify_dead); + cpuhp_setup_state_multi(CPUHP_AP_BLK_MQ_ONLINE, "block/mq:online", + NULL, blk_mq_hctx_notify_online); return 0; } subsys_initcall(blk_mq_init); diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 739b372a5112..651dadd9be12 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -2012,7 +2012,7 @@ static int loop_add(struct loop_device **l, int i) lo->tag_set.queue_depth =3D 128; lo->tag_set.numa_node =3D NUMA_NO_NODE; lo->tag_set.cmd_size =3D sizeof(struct loop_cmd); - lo->tag_set.flags =3D BLK_MQ_F_SHOULD_MERGE; + lo->tag_set.flags =3D BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_NO_MANAGED_IRQ; lo->tag_set.driver_data =3D lo; =20 err =3D blk_mq_alloc_tag_set(&lo->tag_set); diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c index 3f8577e2c13b..5f1ff70ac029 100644 --- a/drivers/md/dm-rq.c +++ b/drivers/md/dm-rq.c @@ -547,7 +547,7 @@ int dm_mq_init_request_queue(struct mapped_device *md= , struct dm_table *t) md->tag_set->ops =3D &dm_mq_ops; md->tag_set->queue_depth =3D dm_get_blk_mq_queue_depth(); md->tag_set->numa_node =3D md->numa_node_id; - md->tag_set->flags =3D BLK_MQ_F_SHOULD_MERGE; + md->tag_set->flags =3D BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_NO_MANAGED_IRQ; md->tag_set->nr_hw_queues =3D dm_get_blk_mq_nr_hw_queues(); md->tag_set->driver_data =3D md; =20 diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h index b669e776d4cb..ca2201435a48 100644 --- a/include/linux/blk-mq.h +++ b/include/linux/blk-mq.h @@ -140,6 +140,8 @@ struct blk_mq_hw_ctx { */ atomic_t nr_active; =20 + /** @cpuhp_online: List to store request if CPU is going to die */ + struct hlist_node cpuhp_online; /** @cpuhp_dead: List to store request if some CPU die. */ struct hlist_node cpuhp_dead; /** @kobj: Kernel object for sysfs. */ @@ -388,6 +390,7 @@ struct blk_mq_ops { enum { BLK_MQ_F_SHOULD_MERGE =3D 1 << 0, BLK_MQ_F_TAG_SHARED =3D 1 << 1, + BLK_MQ_F_NO_MANAGED_IRQ =3D 1 << 2, BLK_MQ_F_BLOCKING =3D 1 << 5, BLK_MQ_F_NO_SCHED =3D 1 << 6, BLK_MQ_F_ALLOC_POLICY_START_BIT =3D 8, diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h index d37c17e68268..8bd2fea6cd59 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -151,6 +151,7 @@ enum cpuhp_state { CPUHP_AP_SMPBOOT_THREADS, CPUHP_AP_X86_VDSO_VMA_ONLINE, CPUHP_AP_IRQ_AFFINITY_ONLINE, + CPUHP_AP_BLK_MQ_ONLINE, CPUHP_AP_ARM_MVEBU_SYNC_CLOCKS, CPUHP_AP_X86_INTEL_EPB_ONLINE, CPUHP_AP_PERF_ONLINE, --=20 2.25.2