Re: [PATCH] block: fix busy device checking in blk_drop_partitions

[Christoph Hellwig <hch@lst.de>]

ping?

On Sat, Apr 04, 2020 at 08:51:20AM +0200, Christoph Hellwig wrote:
> bd_super is only set by get_tree_bdev and mount_bdev, and thus not by
> other openers like btrfs or the XFS realtime and log devices, as well as
> block devices directly opened from user space.  Check bd_openers
> instead.
> 
> Fixes: 77032ca66f86 ("Return EBUSY from BLKRRPART for mounted whole-dev fs")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/partitions/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/partitions/core.c b/block/partitions/core.c
> index b79c4513629b..1a0a829d8416 100644
> --- a/block/partitions/core.c
> +++ b/block/partitions/core.c
> @@ -496,7 +496,7 @@ int blk_drop_partitions(struct gendisk *disk, struct block_device *bdev)
>  
>  	if (!disk_part_scan_enabled(disk))
>  		return 0;
> -	if (bdev->bd_part_count || bdev->bd_super)
> +	if (bdev->bd_part_count || bdev->bd_openers)
>  		return -EBUSY;
>  	res = invalidate_partition(disk, 0);
>  	if (res)
> -- 
> 2.25.1
---end quoted text---