From: "hch@infradead.org" <hch@infradead.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Keith Busch <kbusch@kernel.org>,
"linux-scsi @ vger . kernel . org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-fsdevel @ vger . kernel . org"
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v4 06/10] scsi: export scsi_mq_uninit_cmnd
Date: Wed, 8 Apr 2020 08:59:31 -0700 [thread overview]
Message-ID: <20200408155931.GD29029@infradead.org> (raw)
In-Reply-To: <SN4PR0401MB3598D625922E9EFCC2F039F09BC00@SN4PR0401MB3598.namprd04.prod.outlook.com>
On Wed, Apr 08, 2020 at 11:32:30AM +0000, Johannes Thumshirn wrote:
> On 07/04/2020 19:00, Christoph Hellwig wrote:
> > - scsi_mq_free_sgtables - yes, this would need to be done by the driver
> > and actually is what undoes scsi_init_io. I think you want to export
> > this instead (and remove the _mq in the name while you are at it)
>
> OK, I was afraid to expose too much internals if I export
> scsi_mq_free_sgtables() but, sure that's a trivial change.
Well, it mirrors scsi_init_io, so if we want to undo scsi_init_io
it seems to be the right export.
next prev parent reply other threads:[~2020-04-08 15:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 10:12 [PATCH v4 00/10] Introduce Zone Append for writing to zoned block devices Johannes Thumshirn
2020-04-03 10:12 ` [PATCH v4 01/10] block: provide fallbacks for blk_queue_zone_is_seq and blk_queue_zone_no Johannes Thumshirn
2020-04-03 10:12 ` [PATCH v4 02/10] block: Introduce REQ_OP_ZONE_APPEND Johannes Thumshirn
2020-04-07 16:48 ` Christoph Hellwig
2020-04-08 11:31 ` Johannes Thumshirn
2020-04-08 15:51 ` Christoph Hellwig
2020-04-08 15:53 ` Johannes Thumshirn
2020-04-03 10:12 ` [PATCH v4 03/10] block: introduce blk_req_zone_write_trylock Johannes Thumshirn
2020-04-07 16:53 ` Christoph Hellwig
2020-04-07 16:54 ` Christoph Hellwig
2020-04-08 8:29 ` [PATCH v4 04/10] block: Modify revalidate zones Damien Le Moal
2020-04-08 15:58 ` hch
2020-04-03 10:12 ` Johannes Thumshirn
2020-04-03 10:12 ` [PATCH v4 05/10] scsi: sd_zbc: factor out sanity checks for zoned commands Johannes Thumshirn
2020-04-03 10:12 ` [PATCH v4 06/10] scsi: export scsi_mq_uninit_cmnd Johannes Thumshirn
2020-04-07 17:00 ` Christoph Hellwig
2020-04-08 11:32 ` Johannes Thumshirn
2020-04-08 15:59 ` hch [this message]
2020-04-03 10:12 ` [PATCH v4 07/10] scsi: sd_zbc: emulate ZONE_APPEND commands Johannes Thumshirn
2020-04-07 17:05 ` Christoph Hellwig
2020-04-08 8:14 ` Damien Le Moal
2020-04-08 15:58 ` hch
2020-04-08 16:13 ` Johannes Thumshirn
2020-04-03 10:12 ` [PATCH v4 08/10] null_blk: Support REQ_OP_ZONE_APPEND Johannes Thumshirn
2020-04-07 17:05 ` Christoph Hellwig
2020-04-03 10:12 ` [PATCH v4 09/10] block: export bio_release_pages and bio_iov_iter_get_pages Johannes Thumshirn
2020-04-03 10:12 ` [PATCH v4 10/10] zonefs: use REQ_OP_ZONE_APPEND for sync DIO Johannes Thumshirn
2020-04-07 16:49 ` [PATCH v4 00/10] Introduce Zone Append for writing to zoned block devices Christoph Hellwig
2020-04-08 8:28 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408155931.GD29029@infradead.org \
--to=hch@infradead.org \
--cc=Damien.LeMoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).