Linux block layer
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Omar Sandoval <osandov@fb.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH blktests] Fix unintended skipping of tests
Date: Thu, 16 Apr 2020 14:44:28 -0700	[thread overview]
Message-ID: <20200416214428.GD701157@vader> (raw)
In-Reply-To: <20200414221151.449946-1-its@irrelevant.dk>

On Wed, Apr 15, 2020 at 12:11:51AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> cd11d001fe86 ("Support skipping tests from test{,_device}()") breaks a
> handful of tests in the block group.
> 
> For example, block/005 uses _test_dev_is_rotational to check if the
> device is rotational and uses the result to size up the fio run. As a
> side-effect, _test_dev_is_rotational also sets SKIP_REASON, which (since
> commit cd11d001fe86) causes the test to print out a "[not run]" even
> through the test actually ran successfully.

Oof, I thought I checked for this sort of thing, but clearly I missed
this one. It might be better to rename the existing helpers _require_foo
(e.g., _require_test_dev_is_rotational), and have the variant without
the _require whenever it's needed. Would you mind writing a patch for
that?

Thanks,
Omar

  reply	other threads:[~2020-04-16 21:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 22:11 [PATCH blktests] Fix unintended skipping of tests Klaus Jensen
2020-04-16 21:44 ` Omar Sandoval [this message]
2020-04-17  7:35   ` Klaus Birkelund Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416214428.GD701157@vader \
    --to=osandov@osandov.com \
    --cc=its@irrelevant.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox