From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0B2C83000 for ; Tue, 28 Apr 2020 06:54:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9C8C206B8 for ; Tue, 28 Apr 2020 06:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726256AbgD1Gyy (ORCPT ); Tue, 28 Apr 2020 02:54:54 -0400 Received: from verein.lst.de ([213.95.11.211]:54378 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgD1Gyy (ORCPT ); Tue, 28 Apr 2020 02:54:54 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C326568C7B; Tue, 28 Apr 2020 08:54:50 +0200 (CEST) Date: Tue, 28 Apr 2020 08:54:50 +0200 From: Christoph Hellwig To: "Paul E. McKenney" Cc: Christoph Hellwig , Ming Lei , Jens Axboe , linux-block@vger.kernel.org, John Garry , Bart Van Assche , Hannes Reinecke , Thomas Gleixner , will@kernel.org, peterz@infradead.org Subject: Re: [PATCH V8 07/11] blk-mq: stop to handle IO and drain IO before hctx becomes inactive Message-ID: <20200428065450.GA18754@lst.de> References: <20200424102351.475641-1-ming.lei@redhat.com> <20200424102351.475641-8-ming.lei@redhat.com> <20200424103851.GD28156@lst.de> <20200425031723.GC477579@T590> <20200425083224.GA5634@lst.de> <20200425093437.GA495669@T590> <20200425095351.GC495669@T590> <20200425154832.GA16004@lst.de> <20200427190337.GK7560@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427190337.GK7560@paulmck-ThinkPad-P72> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Apr 27, 2020 at 12:03:37PM -0700, Paul E. McKenney wrote: > On Sat, Apr 25, 2020 at 05:48:32PM +0200, Christoph Hellwig wrote: > > FYI, here is what I think we should be doing (but the memory model > > experts please correct me): > > I would be happy to, but could you please tell me what to apply this > against? I made several wrong guesses, and am not familiar enough with > this code to evaluate this patch in isolation. Here is a link to the whole series on lore: https://lore.kernel.org/linux-block/1eba973b-25cf-88bd-7284-d86730b4ddf2@kernel.dk/T/#t