From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 3/4] block: replace BIO_QUEUE_ENTERED with BIO_CGROUP_ACCT
Date: Tue, 28 Apr 2020 16:24:56 +0200 [thread overview]
Message-ID: <20200428142456.GB5646@lst.de> (raw)
In-Reply-To: <SN4PR0401MB35988020B036B6E1A2D974129BAC0@SN4PR0401MB3598.namprd04.prod.outlook.com>
On Tue, Apr 28, 2020 at 02:23:52PM +0000, Johannes Thumshirn wrote:
> This is completely unrelated to the patch, but why is
> blkcg_bio_issue_check() static inline? It's only called in
> generic_make_request_checks().
The whole blk-cgroup group is just crazy :( This isn't even the worst
part of it.
next prev parent reply other threads:[~2020-04-28 14:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 11:27 a few small bio related cleanups Christoph Hellwig
2020-04-28 11:27 ` [PATCH 1/4] block: improve the submit_bio and generic_make_request documentation Christoph Hellwig
2020-04-28 14:16 ` Johannes Thumshirn
2020-04-28 14:17 ` Keith Busch
2020-04-28 11:27 ` [PATCH 2/4] block: cleanup the memory stall accounting in submit_bio Christoph Hellwig
2020-04-28 14:12 ` Johannes Thumshirn
2020-04-28 14:21 ` Christoph Hellwig
2020-04-28 15:06 ` Johannes Weiner
2020-04-28 11:27 ` [PATCH 3/4] block: replace BIO_QUEUE_ENTERED with BIO_CGROUP_ACCT Christoph Hellwig
2020-04-28 14:23 ` Johannes Thumshirn
2020-04-28 14:24 ` Christoph Hellwig [this message]
2020-04-28 14:26 ` Johannes Thumshirn
2020-04-28 11:27 ` [PATCH 4/4] block: add a bio_queue_enter helper Christoph Hellwig
2020-04-28 14:55 ` Johannes Thumshirn
2020-04-29 15:33 ` a few small bio related cleanups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428142456.GB5646@lst.de \
--to=hch@lst.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=hannes@cmpxchg.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).