* [PATCH] blk-mq: make function '__blk_mq_sched_dispatch_requests' static
@ 2020-04-29 1:36 Zheng Bin
2020-04-29 7:26 ` Christoph Hellwig
2020-04-29 15:17 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Zheng Bin @ 2020-04-29 1:36 UTC (permalink / raw)
To: axboe, linux-block; +Cc: zhengbin13
Fix sparse warnings:
block/blk-mq-sched.c:209:5: warning: symbol '__blk_mq_sched_dispatch_requests' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
block/blk-mq-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
index 702ce525933c..fdcc2c1dd178 100644
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -206,7 +206,7 @@ static int blk_mq_do_dispatch_ctx(struct blk_mq_hw_ctx *hctx)
return ret;
}
-int __blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx)
+static int __blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx)
{
struct request_queue *q = hctx->queue;
struct elevator_queue *e = q->elevator;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-mq: make function '__blk_mq_sched_dispatch_requests' static
2020-04-29 1:36 [PATCH] blk-mq: make function '__blk_mq_sched_dispatch_requests' static Zheng Bin
@ 2020-04-29 7:26 ` Christoph Hellwig
2020-04-29 15:17 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-04-29 7:26 UTC (permalink / raw)
To: Zheng Bin; +Cc: axboe, linux-block
On Wed, Apr 29, 2020 at 09:36:32AM +0800, Zheng Bin wrote:
> Fix sparse warnings:
>
> block/blk-mq-sched.c:209:5: warning: symbol '__blk_mq_sched_dispatch_requests' was not declared. Should it be static?
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-mq: make function '__blk_mq_sched_dispatch_requests' static
2020-04-29 1:36 [PATCH] blk-mq: make function '__blk_mq_sched_dispatch_requests' static Zheng Bin
2020-04-29 7:26 ` Christoph Hellwig
@ 2020-04-29 15:17 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-04-29 15:17 UTC (permalink / raw)
To: Zheng Bin, linux-block
On 4/28/20 7:36 PM, Zheng Bin wrote:
> Fix sparse warnings:
>
> block/blk-mq-sched.c:209:5: warning: symbol '__blk_mq_sched_dispatch_requests' was not declared. Should it be static?
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-29 15:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-29 1:36 [PATCH] blk-mq: make function '__blk_mq_sched_dispatch_requests' static Zheng Bin
2020-04-29 7:26 ` Christoph Hellwig
2020-04-29 15:17 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).