From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAFF4C8300A for ; Thu, 30 Apr 2020 13:13:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CC84208CA for ; Thu, 30 Apr 2020 13:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726550AbgD3NN5 (ORCPT ); Thu, 30 Apr 2020 09:13:57 -0400 Received: from verein.lst.de ([213.95.11.211]:40633 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726520AbgD3NN4 (ORCPT ); Thu, 30 Apr 2020 09:13:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id A164968D07; Thu, 30 Apr 2020 15:13:52 +0200 (CEST) Date: Thu, 30 Apr 2020 15:13:52 +0200 From: Christoph Hellwig To: Stefan Haberland Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org, hoeppner@linux.ibm.com, linux-s390@vger.kernel.org, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver Message-ID: <20200430131351.GA24813@lst.de> References: <20200430111754.98508-1-sth@linux.ibm.com> <20200430111754.98508-2-sth@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430111754.98508-2-sth@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Apr 30, 2020 at 01:17:54PM +0200, Stefan Haberland wrote: > Remove the calls to ioctl_by_bdev from the DASD partition detection code > to enable the removal of the specific code. > > To do so reuse the gendisk private_data pointer and not only provide a > pointer to the devmap but provide a new structure containing a pointer > to the devmap as well as all required information for the partition > detection. This makes it independent from the dasd_information2_t > structure. I think sharing the data structure in private data is pretty dangerous. In the meantime I thought of another idea - the partition code could do a symbol_get of a symbol exported by the dasd driver and use that to query the information.