From: Ming Lei <ming.lei@redhat.com>
To: axboe@kernel.dk, tom.leiming@gmail.com, bvanassche@acm.org,
linux-block@vger.kernel.org
Subject: Re: [RESEND v4 6/6] block: rename blk_mq_alloc_rq_maps
Date: Sun, 3 May 2020 11:37:27 +0800 [thread overview]
Message-ID: <20200503033727.GC1128091@T590> (raw)
In-Reply-To: <35b2fc8a9648ed16c9a465fd43c928d4393d1c4a.1588080449.git.zhangweiping@didiglobal.com>
On Tue, Apr 28, 2020 at 09:30:28PM +0800, Weiping Zhang wrote:
> rename blk_mq_alloc_rq_maps to blk_mq_alloc_map_and_requests,
> this function allocs both map and request, make function name align
> with funtion.
>
> Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
> ---
> block/blk-mq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index b6c907dbbb30..8ae9e375fe53 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -3017,7 +3017,7 @@ static int blk_mq_realloc_map_and_requests(struct blk_mq_tag_set *set, int new)
> * may reduce the depth asked for, if memory is tight. set->queue_depth
> * will be updated to reflect the allocated depth.
> */
> -static int blk_mq_alloc_rq_maps(struct blk_mq_tag_set *set)
> +static int blk_mq_alloc_map_and_requests(struct blk_mq_tag_set *set)
> {
> unsigned int depth;
> int err;
> @@ -3177,7 +3177,7 @@ int blk_mq_alloc_tag_set(struct blk_mq_tag_set *set)
> if (ret)
> goto out_free_mq_map;
>
> - ret = blk_mq_alloc_rq_maps(set);
> + ret = blk_mq_alloc_map_and_requests(set);
> if (ret)
> goto out_free_mq_map;
>
> --
> 2.18.1
>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
prev parent reply other threads:[~2020-05-03 3:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1588080449.git.zhangweiping@didiglobal.com>
2020-04-28 13:29 ` [RESEND v4 1/6] block: free both rq_map and request Weiping Zhang
2020-05-03 2:49 ` Ming Lei
2020-04-28 13:29 ` [RESEND v4 2/6] block: save previous hardware queue count before udpate Weiping Zhang
2020-05-03 2:50 ` Ming Lei
2020-04-28 13:29 ` [RESEND v4 3/6] block: refactor __blk_mq_alloc_rq_maps Weiping Zhang
2020-04-28 13:29 ` [RESEND v4 4/6] block: alloc map and request for new hardware queue Weiping Zhang
2020-05-03 3:21 ` Ming Lei
2020-05-05 4:14 ` Weiping Zhang
2020-04-28 13:30 ` [RESEND v4 5/6] block: rename __blk_mq_alloc_rq_map Weiping Zhang
2020-05-03 3:36 ` Ming Lei
2020-04-28 13:30 ` [RESEND v4 6/6] block: rename blk_mq_alloc_rq_maps Weiping Zhang
2020-05-03 3:37 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200503033727.GC1128091@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).