From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DAD6C3A5A9 for ; Mon, 4 May 2020 14:03:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E86DC20705 for ; Mon, 4 May 2020 14:03:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="A6lA6daS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728417AbgEDODR (ORCPT ); Mon, 4 May 2020 10:03:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728233AbgEDODR (ORCPT ); Mon, 4 May 2020 10:03:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AD7EC061A0E; Mon, 4 May 2020 07:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bK0B4AjAiw8HEQFzfeTV0caEn+nTqXTEfS3l1nfwGB4=; b=A6lA6daSe8GZF6vbqqJUbTAnhb uUPI5wEnPD3L/wMkNIezQRsteDGupDVFLy1XZ93LnIJW3wCb0yoMBlV5v7CL/AHzmY0QaPpsM9mv8 bx/6ta7IeMdyMte+HGBdg0nMLZldEq36pSgUIaP5KC89R1Xh6rV9MLcoy11j7Bee5VhrRLu88VJBD teNjtZrPXKzAZqbspijjOX5Yz3EZKRXU+gaAauZfTeUdBhJ1QWXXvQeTjy79nRwW0lGCTuOfEYM58 EtG2bxt9M9NFSjoudnrZgTOyohV2XozrCi6RXpAqFGLCnHg4Ps7Wqs1SnOzNdycflyPULx5HQbXPw gGgRf06A==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVbgj-0002lS-1l; Mon, 04 May 2020 14:03:17 +0000 Date: Mon, 4 May 2020 07:03:17 -0700 From: Christoph Hellwig To: Konstantin Khlebnikov Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe Subject: Re: [PATCH 2/4] block/part_stat: use __this_cpu_add() instead of access by smp_processor_id() Message-ID: <20200504140317.GB29020@infradead.org> References: <158859896942.19836.15240144203131230746.stgit@buzz> <158859897252.19836.5614675872684760741.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158859897252.19836.5614675872684760741.stgit@buzz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > +#define __part_stat_add(part, field, addnd) \ > + (part_stat_get(part, field) += (addnd)) Just open coding part_stat_get for the UP side would seems a little easier to read. Otherwise this looks good: Reviewed-by: Christoph Hellwig