From: Christoph Hellwig <hch@infradead.org>
To: axboe@kernel.dk, tom.leiming@gmail.com, bvanassche@acm.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH v5 4/5] block: rename __blk_mq_alloc_rq_map
Date: Wed, 6 May 2020 23:11:41 -0700 [thread overview]
Message-ID: <20200507061141.GC23530@infradead.org> (raw)
In-Reply-To: <7eaff8fdfc394ecb686abb186564d9e1aebcf9ae.1588660550.git.zhangweiping@didiglobal.com>
On Tue, May 05, 2020 at 02:45:58PM +0800, Weiping Zhang wrote:
> rename __blk_mq_alloc_rq_map to __blk_mq_alloc_map_and_request,
> actually it alloc both map and request, make function name
> align with function.
>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
> ---
> block/blk-mq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index c6ba94cba17d..02af33f56daa 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2473,7 +2473,7 @@ static void blk_mq_init_cpu_queues(struct request_queue *q,
> }
> }
>
> -static bool __blk_mq_alloc_rq_map(struct blk_mq_tag_set *set, int hctx_idx)
> +static bool __blk_mq_alloc_map_and_request(struct blk_mq_tag_set *set, int hctx_idx)
Please fix the > 80 char line here.
next prev parent reply other threads:[~2020-05-07 6:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 6:43 [PATCH v5 0/5] Fix potential kernel panic when increase hardware queue Weiping Zhang
2020-05-05 6:43 ` [PATCH v5 1/5] block: free both rq_map and request Weiping Zhang
2020-05-07 6:10 ` Christoph Hellwig
2020-05-05 6:43 ` [PATCH v5 2/5] block: save previous hardware queue count before udpate Weiping Zhang
2020-05-07 6:11 ` Christoph Hellwig
2020-05-05 6:45 ` [PATCH v5 4/5] block: rename __blk_mq_alloc_rq_map Weiping Zhang
2020-05-07 6:11 ` Christoph Hellwig [this message]
2020-05-07 12:59 ` Weiping Zhang
2020-05-05 6:46 ` [PATCH v5 5/5] block: rename blk_mq_alloc_rq_maps Weiping Zhang
2020-05-07 6:11 ` Christoph Hellwig
2020-05-05 7:02 ` [PATCH v5 3/5] block: alloc map and request for new hardware queue Weiping Zhang
2020-05-05 7:38 ` [RESEND PATCH " Weiping Zhang
2020-05-07 6:13 ` [PATCH " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507061141.GC23530@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).