From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Satya Tangirala <satyat@google.com>
Subject: Re: [PATCH] block: fix build failure in case of !CONFIG_BLOCK
Date: Thu, 14 May 2020 16:12:21 +0800 [thread overview]
Message-ID: <20200514081221.GK2073570@T590> (raw)
In-Reply-To: <20200514064133.GA5058@infradead.org>
On Wed, May 13, 2020 at 11:41:33PM -0700, Christoph Hellwig wrote:
> Can you please just move the function out of line? If we context
> switch it is by definition to performance critical enough to be an
> inline function bloating the callers..
>
Looks blk_io_schedule() is only called from CONFG_BLOCK code, so it is
better to export it as one symbol.
Thanks,
Ming
prev parent reply other threads:[~2020-05-14 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 1:43 [PATCH] block: fix build failure in case of !CONFIG_BLOCK Ming Lei
2020-05-14 6:41 ` Christoph Hellwig
2020-05-14 8:12 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514081221.GK2073570@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox