From: Eric Biggers <ebiggers@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, Satya Tangirala <satyat@google.com>
Subject: Re: [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err
Date: Tue, 26 May 2020 16:20:50 -0700 [thread overview]
Message-ID: <20200526232050.GB182086@gmail.com> (raw)
In-Reply-To: <20200526224902.63975-1-colin.king@canonical.com>
On Tue, May 26, 2020 at 11:49:02PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable err is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> block/blk-crypto-fallback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c
> index 74ab137ae3ba..6e49688a2d80 100644
> --- a/block/blk-crypto-fallback.c
> +++ b/block/blk-crypto-fallback.c
> @@ -529,7 +529,7 @@ static bool blk_crypto_fallback_inited;
> static int blk_crypto_fallback_init(void)
> {
> int i;
> - int err = -ENOMEM;
> + int err;
>
> if (blk_crypto_fallback_inited)
> return 0;
Looks good, you can add:
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2020-05-26 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 22:49 [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err Colin King
2020-05-26 23:20 ` Eric Biggers [this message]
2020-05-26 23:27 ` [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err' Satya Tangirala
2020-05-27 11:42 ` [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526232050.GB182086@gmail.com \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).