From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
linux-block@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCHv2 1/2] blk-mq: export __blk_mq_complete_request
Date: Fri, 29 May 2020 14:26:50 +0200 [thread overview]
Message-ID: <20200529122650.GA28107@lst.de> (raw)
In-Reply-To: <20200528181807.GA3504306@dhcp-10-100-145-180.wdl.wdc.com>
On Thu, May 28, 2020 at 11:18:07AM -0700, Keith Busch wrote:
> On Thu, May 28, 2020 at 06:42:56PM +0200, Christoph Hellwig wrote:
> > I think this needs a better name.
>
> blk_mq_do_complete_req()?
do isn't exactly descriptive, is it?
blk_mq_force_complete_request maybe?
And yes, I think for 5.9 we need to lift the error injection into the
callers, this is a mess..
next prev parent reply other threads:[~2020-05-29 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 15:19 [PATCHv2 1/2] blk-mq: export __blk_mq_complete_request Keith Busch
2020-05-28 15:19 ` [PATCHv2 2/2] nvme: cancel requests for real Keith Busch
2020-05-28 15:23 ` Johannes Thumshirn
2020-05-28 15:22 ` [PATCHv2 1/2] blk-mq: export __blk_mq_complete_request Johannes Thumshirn
2020-05-28 15:29 ` Jens Axboe
2020-05-28 16:42 ` Christoph Hellwig
2020-05-28 18:18 ` Keith Busch
2020-05-29 12:26 ` Christoph Hellwig [this message]
2020-05-29 3:44 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529122650.GA28107@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).