Linux block layer
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: harshad shirwadkar <harshadshirwadkar@gmail.com>
Cc: linux-block@vger.kernel.org, "Theodore Y. Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] block: add split_alignment for request queue
Date: Tue, 16 Jun 2020 12:16:24 +0800	[thread overview]
Message-ID: <20200616041624.GA52855@T590> (raw)
In-Reply-To: <CAD+ocbzP70UXWRdhx-j2=+DdGihEbP94Djksij_Ykzgaayim3Q@mail.gmail.com>

On Mon, Jun 15, 2020 at 08:24:08PM -0700, harshad shirwadkar wrote:
> After taking a closer look, I don't see chunk_sectors being accounted
> for in the splitting code. If I understand correctly, the implementation
> of chunk_sectors is such that it allows for one big IO to go through.
> In other words, it tries to avoid the splitting code if possible. But,
> it doesn't seem to guarantee that when an IO is split, it will be

Please take a look at blk_max_size_offset() which is called by
get_max_io_size() from blk_bio_segment_split(), which splits
bio into chunk_sectors aligned bio.

Also you may run IO trace on queue with chunk_sectors setup, and check
if the splitted IO request is what you expected.


Thanks, 
Ming


  reply	other threads:[~2020-06-16  4:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16  0:56 [PATCH] block: add split_alignment for request queue Harshad Shirwadkar
2020-06-16  2:14 ` John Dorminy
2020-06-16  2:25   ` Martin K. Petersen
2020-06-16  2:40 ` Ming Lei
2020-06-16  2:50   ` harshad shirwadkar
2020-06-16  3:24     ` harshad shirwadkar
2020-06-16  4:16       ` Ming Lei [this message]
2020-06-16  7:29 ` Christoph Hellwig
2020-06-16 11:12   ` Sweet Tea Dorminy
2020-06-16 14:38     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200616041624.GA52855@T590 \
    --to=ming.lei@redhat.com \
    --cc=harshadshirwadkar@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox