From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Paolo Valente <paolo.valente@linaro.org>
Subject: Re: [PATCH] blktrace: Provide event for request merging
Date: Thu, 18 Jun 2020 18:13:31 +0200 [thread overview]
Message-ID: <20200618161331.GD9664@quack2.suse.cz> (raw)
In-Reply-To: <20200618065359.GA24943@infradead.org>
On Wed 17-06-20 23:53:59, Christoph Hellwig wrote:
> On Wed, Jun 17, 2020 at 03:58:23PM +0200, Jan Kara wrote:
> > blk_account_io_merge_request(next);
> >
> > + trace_block_rq_merge(q, next);
>
> q can be derived from next, no need to explicitly pass it. And yes,
> I know a lot of existing tracepoints do so, but I plan to fix that up
> as well.
I had a look into it now and I could do this but that would mean that
block_rq_merge trace event would now differ from all other similar events
and we couldn't use block_rq event class and have to define our own and so
overall it would IMO make future conversion to get rid of 'q' argument more
difficult, not simpler. So I can do this but are you really sure?
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-06-18 16:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 13:58 [PATCH] blktrace: Provide event for request merging Jan Kara
2020-06-17 17:41 ` Chaitanya Kulkarni
2020-06-18 12:04 ` Jan Kara
2020-06-18 15:36 ` Chaitanya Kulkarni
2020-06-18 6:53 ` Christoph Hellwig
2020-06-18 12:05 ` Jan Kara
2020-06-18 16:13 ` Jan Kara [this message]
2020-06-18 17:31 ` Chaitanya Kulkarni
2020-06-19 6:52 ` Christoph Hellwig
2020-06-25 19:51 ` Jan Kara
2020-06-26 0:03 ` Chaitanya Kulkarni
2020-06-26 3:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618161331.GD9664@quack2.suse.cz \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).