From: Mike Snitzer <snitzer@redhat.com>
To: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Cc: Ewan Milne <emilne@redhat.com>, Hannes Reinecke <hare@suse.de>,
John Meneghini <johnm@netapp.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
dm-devel@redhat.com
Subject: NVMe regression, NVMe no longer uses blk_path_error()
Date: Wed, 1 Jul 2020 12:39:42 -0400 [thread overview]
Message-ID: <20200701163942.GB27063@redhat.com> (raw)
IF NVMe's isn't a primary user of blk_path_error() it largely kills
the entire point of blk_path_error(). (And no the response to this must
not be: "that's fine")
This commit shows NVMe's previous continued use of blk_path_error():
8decf5d5b9f3f7 ("nvme: remove nvme_req_needs_failover")
but then nvme_failover_req() was relatively recently refactored with:
764e9332098c0 ("nvme-multipath: do not reset on unknown status")
NVMe should've continued to use blk_path_error(). If there was some gap
in error classification that should've been fixed in NVMe.
Instead, with commit 764e9332098c0 NVMe is no longer using retryable
error classifications commonly maintained within block core. As such it
introduces serious potential for regression with DM multipath no longer
having a shared understanding for what _really_ constitutes a retryable
blk_status_t from NVMe.
Mike
reply other threads:[~2020-07-01 17:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701163942.GB27063@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=johnm@netapp.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).